Ubuntu UI Toolkit

Code review comment for lp:~loic.molinari/ubuntu-ui-toolkit/uitk-use-dedicated-qt-build-define-for-libs

  1. uitk-use-dedicated-qt-build-define-for-libs
  2. Merge into staging
Revision history for this message
Zsombor Egri (zsombi) wrote :

> > Isn't this QT_BUILD_*_LIB declared only if we build as Qt submodule?
>
> No, qt_module.prf (loaded by our ubuntu_qt_module.prf used for libs) defines
> that:
>
> ucmodule = $$upper($$MODULE)
> DEFINES += QT_BUILD_$${ucmodule}_LIB
>
> (they even the uc prefix!)
Excellent! We're good then with this too!

review: Approve

« Back to merge proposal