Merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-y-flip-fix into lp:ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Merged
Approved by: Tim Peeters
Approved revision: 1487
Merged at revision: 1488
Proposed branch: lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-y-flip-fix
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 11 lines (+1/-1)
1 file modified
modules/Ubuntu/Components/plugin/ucubuntushape.cpp (+1/-1)
To merge this branch: bzr merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-y-flip-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+256833@code.launchpad.net

Commit message

[UbuntuShape] FBO redirected shapes must be y-flipped only when not rotated.

Description of the change

[UbuntuShape] FBO redirected shapes must be y-flipped only when not rotated.

To post a comment you must log in.
Revision history for this message
Tim Peeters (tpeeters) wrote :

It works

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/Ubuntu/Components/plugin/ucubuntushape.cpp'
--- modules/Ubuntu/Components/plugin/ucubuntushape.cpp 2015-04-16 11:59:56 +0000
+++ modules/Ubuntu/Components/plugin/ucubuntushape.cpp 2015-04-20 15:29:21 +0000
@@ -167,7 +167,7 @@
167167
168 // Send screen-space derivative factors. Note that when rendering is redirected to a168 // Send screen-space derivative factors. Note that when rendering is redirected to a
169 // ShaderEffectSource (FBO), dFdy() sign is flipped.169 // ShaderEffectSource (FBO), dFdy() sign is flipped.
170 const bool flipped = dfdtFactors[0] != 0.0f && state.projectionMatrix()(1, 3) < 0.0f;170 const bool flipped = dfdtFactors[0] != 1.0f && state.projectionMatrix()(1, 3) < 0.0f;
171 const QVector2D dfdtFactorsVector(dfdtFactors[0], flipped ? -dfdtFactors[1] : dfdtFactors[1]);171 const QVector2D dfdtFactorsVector(dfdtFactors[0], flipped ? -dfdtFactors[1] : dfdtFactors[1]);
172 program()->setUniformValue(m_dfdtFactorsId, dfdtFactorsVector);172 program()->setUniformValue(m_dfdtFactorsId, dfdtFactorsVector);
173173

Subscribers

People subscribed via source and target branches