Merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-1354753 into lp:ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1335
Merged at revision: 1336
Proposed branch: lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-1354753
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 24 lines (+9/-5)
1 file modified
modules/Ubuntu/Components/plugin/shapeitem.cpp (+9/-5)
To merge this branch: bzr merge lp:~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-1354753
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+242195@code.launchpad.net

Commit message

[UbuntuShape] Added detailed doc for borderSource.

Description of the change

[UbuntuShape] Added detailed doc for borderSource.

To post a comment you must log in.
Revision history for this message
Zsombor Egri (zsombi) wrote :

A small comment inline.

review: Needs Fixing
Revision history for this message
Loïc Molinari (loic.molinari) :
1335. By Loïc Molinari

[UbuntuShape] Removed sentence from borderSource doc.

Revision history for this message
Zsombor Egri (zsombi) wrote :

Thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'modules/Ubuntu/Components/plugin/shapeitem.cpp'
--- modules/Ubuntu/Components/plugin/shapeitem.cpp 2014-09-10 18:04:50 +0000
+++ modules/Ubuntu/Components/plugin/shapeitem.cpp 2014-11-19 12:23:24 +0000
@@ -84,11 +84,15 @@
84*/84*/
8585
86/*!86/*!
87 \deprecated87 \qmlproperty string UbuntuShape::borderSource
88 \qmlproperty url UbuntuShape::borderSource88
8989 This property defines the look of the shape borders. The supported strings
90 The image used as a border.90 are \c "radius_idle.sci" providing an idle button style and
91 We plan to expose that feature through styling properties.91 "radius_pressed.sci" providing a pressed button style. Any other strings
92 (like the empty one "") disables styling. Default value is \c
93 "radius_idle.sci".
94
95 \note We plan to expose that feature through styling properties.
92*/96*/
9397
94/*!98/*!

Subscribers

People subscribed via source and target branches