Code review comment for lp:~logan/ubuntu/quantal/xinetd/debian-merge

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

As you do a lot of work for ubuntu, here is a slightly more *picky* review =)

"- debian/xinetd.init: Add the 'status' action." is no longer needed, as we ship an upstart job (which takes precedence) and has status.

In Ubuntu, we do not have "non-maintainer uploads", and sponsors include both changelog entries on the upload (such that we get LP:# closes lines from ). So I would not include "*Non-maintainer..."

Including/copy-pasting "CVE" entry is good, cause well it's a CVE =)

« Back to merge proposal