Code review comment for ~lofidevops/ols-jenkaas:sn1780-mergebot-dependent-branches

Revision history for this message
Emma Brostrom (emmabrostrom) wrote :

Thanks for this David, looks great! I wanted to mention one thing - this approach is only inclusive of git repositories, and some of ours are bzr. I think you'll want to add some logic that takes into account bzr proposals. Here is an example of what that logic could look like: https://git.launchpad.net/tarmac/tree/tarmac/bin/commands.py#n357. I haven't thought too much about the implementation, but it could look like using the LandBzrProposal and LandGitProposal subclasses of LandApprovedProposals.

« Back to merge proposal