Merge ~lloydwaltersj/maas:backport-1807725-3.2 into maas:3.2
Proposed by
Jack Lloyd-Walters
Status: | Merged |
---|---|
Approved by: | Alexsander de Souza |
Approved revision: | 9218a781c17d0cc456327d9d35c4b0fddce6d049 |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~lloydwaltersj/maas:backport-1807725-3.2 |
Merge into: | maas:3.2 |
Diff against target: |
138 lines (+73/-3) 4 files modified
src/maasserver/models/staticipaddress.py (+9/-2) src/maasserver/models/tests/test_staticipaddress.py (+45/-1) src/maasserver/utils/dns.py (+10/-0) src/maasserver/utils/tests/test_dns.py (+9/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexsander de Souza | Approve | ||
MAAS Lander | Approve | ||
Review via email: mp+444180@code.launchpad.net |
Commit message
Fix incorrect hostname from interface name
MAAS currently creates a DNS record for each interface in a host
by simply using its interface name. Whenever an interface has the
'_' character, the code uses it anyway, which is currently breaking
bind as this character is not allowed on domain names.
This patch fixes that by verifying it and replacing the incorrect
character.
LP: #1807725
(cherry picked from commit 83b123eb37b88dd
To post a comment you must log in.
UNIT TESTS 1807725- 3.2 lp:~lloydwaltersj/maas/+git/maas into -b 3.2 lp:~maas-committers/maas
-b backport-
STATUS: FAILED maas-ci. internal: 8080/job/ maas-tester/ 2671/console 48f984c96286df8 46fd292037
LOG: http://
COMMIT: fb745a3e45ea6f9