Merge ~lloydwaltersj/maas:fix-yaml-dump into maas:master

[Jack Lloyd-Walters]

fix openapi output

: https://docs.djangoproject.com/en/3.2/howto/custom-management-commands/#management-commands-outputChange from using sys.stdout to self.stdout as per django recomendation

7069477... by Jack Lloyd-Walters on 2022-08-26

remove changes from seperate branch

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-yaml-dump lp:~lloydwaltersj/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 706947769bc3d96d6c2d3a342cc529c881ea6939

review: Approve

[Adam Collard (adam-collard)]

What does this change? Why is this code better? Can you add a test that fails before and passes now?

review: Needs Fixing

b8cd63d... by Jack Lloyd-Walters on 2022-08-26

add some tests

2e73204... by Jack Lloyd-Walters on 2022-08-26

remove pointless tests

94f9263... by Jack Lloyd-Walters on 2022-08-26

formatting and lint

671ebd5... by Jack Lloyd-Walters on 2022-08-26

formatting and lint

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-yaml-dump lp:~lloydwaltersj/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 671ebd5f63867f88911e6bb8a4575e16222a142f

review: Approve

139ad39... by Jack Lloyd-Walters on 2022-08-30

address comments

[MAAS Lander (maas-lander)]

UNIT TESTS
-b fix-yaml-dump lp:~lloydwaltersj/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 139ad39763dcf750fbd5180fffe17b069c789a2d

review: Approve

[Adam Collard (adam-collard)]

review: Approve

diff --git a/src/maasserver/management/commands/generate_oapi_spec.py b/src/maasserver/management/commands/generate_oapi_spec.py
index 096d779..3c25a13 100644
--- a/src/maasserver/management/commands/generate_oapi_spec.py
+++ b/src/maasserver/management/commands/generate_oapi_spec.py
@@ -13,4 +13,4 @@ class Command(BaseCommand):
     def handle(self, *args, **options):
         oapi = get_api_endpoint()
         oapi["externalDocs"]["url"] = "https://maas.io/docs"
-        yaml.dump(oapi, self.stdout)
+        self.stdout.write(yaml.dump(oapi))
diff --git a/src/maasserver/management/commands/tests/test_generate_oapi.py b/src/maasserver/management/commands/tests/test_generate_oapi.py
new file mode 100644
index 0000000..2c49814
--- /dev/null
+++ b/src/maasserver/management/commands/tests/test_generate_oapi.py
@@ -0,0 +1,22 @@
+# Copyright 2022 Canonical Ltd.  This software is licensed under the
+# GNU Affero General Public License version 3 (see the file LICENSE).
+
+"""Test OpenApi commands work correctly."""
+
+
+from io import StringIO
+
+from django.core.management import call_command
+import yaml
+
+from maasserver.api.doc_oapi import get_api_endpoint
+from maastesting.testcase import MAASTestCase
+
+
+class TestOAPIDoc(MAASTestCase):
+    def test_generate_spec(self):
+        spec = get_api_endpoint()
+        spec["externalDocs"]["url"] = "https://maas.io/docs"
+        out = StringIO()
+        call_command("generate_oapi_spec", stdout=out)
+        self.assertEqual(yaml.dump(spec), out.getvalue())