Merge lp:~liuyq0307/linaro-android-build-tools/binaries-default-false into lp:linaro-android-build-tools

Proposed by Yongqin Liu
Status: Merged
Merged at revision: 503
Proposed branch: lp:~liuyq0307/linaro-android-build-tools/binaries-default-false
Merge into: lp:linaro-android-build-tools
Diff against target: 16 lines (+4/-2)
1 file modified
build-scripts/post-build-lava.py (+4/-2)
To merge this branch: bzr merge lp:~liuyq0307/linaro-android-build-tools/binaries-default-false
Reviewer Review Type Date Requested Status
vishal (community) Approve
Paul Sokolovsky Approve
Linaro Infrastructure Pending
Vishal Pending
Review via email: mp+123228@code.launchpad.net

Description of the change

according to Vishal, LAVA_ANDROID_BINARIES is relevant only for panda

To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Looks good.

Revision history for this message
Paul Sokolovsky (pfalcon) :
review: Approve
Revision history for this message
vishal (vishalbhoj) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'build-scripts/post-build-lava.py'
--- build-scripts/post-build-lava.py 2012-08-14 04:00:42 +0000
+++ build-scripts/post-build-lava.py 2012-09-07 08:17:18 +0000
@@ -220,8 +220,10 @@
220 # User can disable the installation of android binaries (doing this will220 # User can disable the installation of android binaries (doing this will
221 # disable hardware acceleration)221 # disable hardware acceleration)
222 enable_android_install_binaries = os.environ.get("LAVA_ANDROID_BINARIES")222 enable_android_install_binaries = os.environ.get("LAVA_ANDROID_BINARIES")
223 if enable_android_install_binaries == None: # Not set, default to True223 # Not set, default to False, because this is relevant only for panda
224 enable_android_install_binaries = True224 # from Vishal
225 if enable_android_install_binaries == None:
226 enable_android_install_binaries = False
225 elif enable_android_install_binaries.lower() in ['1', 'true', 'yes']:227 elif enable_android_install_binaries.lower() in ['1', 'true', 'yes']:
226 enable_android_install_binaries = True228 enable_android_install_binaries = True
227 else:229 else:

Subscribers

People subscribed via source and target branches