Code review comment for lp:~liuyq0307/lava-scheduler/fix-861149

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

On 13 October 2011 21:01, Zygmunt Krynicki
<email address hidden>wrote:

> For the record:
>
> 1) lava-server already uses GMT as anything else is broken by django design
> 2) All timestamps and dates in the database must use GMT/UTC
> 3) We can render timestamps with any offsets, this is a user preference
>
> There is a bug somewhere that, most likely, records the wrong date in the
> database but this patch does not address that IMO.
>
In method getJobForBoard_impl, the start_time is utc time, but the commit
use it as local time to store into database,
I will look into the code deeper to see why the transaction commit does as
such.

« Back to merge proposal