LAVA master image scripts

Code review comment for lp:~liuyq0307/lava-master-image-scripts/add-sdcard

add-sdcard
Merge into trunk

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2012-06-18:

<liuyq> could you help to try this branch https://code.launchpad.net/~liuyq0307/lava-master-image-scripts/add-sdcard with a imx53 or origen board?
<liuyq> davepigott, I have tested with panda, it works
<zyga> liuyq, would you mind opening a merge request
even if it is still work in progress
(mark it as such if needed)
<davepigott> liuyq: Will test
<liuyq> davepigott, thanks, and I submitted a MP for it. https://code.launchpad.net/~liuyq0307/lava-master-image-scripts/add-sdcard/+merge/110770
<liuyq> davepigott, springz has used it with his imx, but there is a problem about the last 8th partition of sdcard.
davepigott, I don't know if the problem has relation to the size of his sdcard, the size is 4G in total.
<davepigott> liuyq: Our recommendation is always to use at least 8GB, but I'll check
<liuyq> davepigott, I am a little afraid that we can't create the 8th partition on imx or origen.
<davepigott> liuyq: I'll find out
<zyga> liuyq, why did you move to kpartx?
<liuyq> zyga, partx does not work on my precise, also not work on springz's natty
<zyga> liuyq, I see
<liuyq> zyga, but kparx works work for both
<zyga> liuyq, I'd prefer that to be a separate patch, and drop the # commented out version of partx
* zyga is not really in a position to tell this as I'm not a lava or validation person anymore
<zyga> but that's what I think
<davepigott> zyga: liuyq I completely agree about the commented out code, and we did say that you had to be on precise to make this work properly
<liuyq> zyga, thanks, I will delete the old partx comment when I merge. Here just for the convenience that if the kpartx does not work for all we can easily rollback
<zyga> davepigott, yes but apparently it's hard for some of the assignees to transition to new os release
sure
liuyq, I'd rather see a version that works on just kpartx than both comments, that'
that's why we have bzr for
<davepigott> liuyq: The default rootfs size we set is 4G so it won't work on a 4G card
<liuyq> davepigott, yes, I told springz to specify the size with the command parameters
<liuyq> davepigott, zyga, BTW, we also have a lava-partition-disk under lava-dispatcher/doc/scripts/lava-partition-disk
<zyga> liuyq, oh, I'm happy to kill it if davepigott doesn't mind
<liuyq> davepigott, zyga, should we delete it? it seems almost the same as the one in lava-master-image-scripts, but a little out of date
<zyga> yes
<davepigott> +1

<liuyq> could you help to try this branch https://code.launchpad.net/~liuyq0307/lava-master-image-scripts/add-sdcard with a imx53 or origen board?
<liuyq> davepigott, I have tested with panda, it works
<zyga> liuyq, would you mind opening a merge request
 even if it is still work in progress
 (mark it as such if needed)
<davepigott> liuyq: Will test
<liuyq> davepigott, thanks, and I submitted a MP for it. https://code.launchpad.net/~liuyq0307/lava-master-image-scripts/add-sdcard/+merge/110770
<liuyq> davepigott, springz has used it with his imx, but there is a problem about the last 8th partition of sdcard.
 davepigott, I don't know if the problem has relation to the size of his sdcard, the size is 4G in total.
<davepigott> liuyq: Our recommendation is always to use at least 8GB, but I'll check
<liuyq> davepigott, I am a little afraid that we can't create the 8th partition on imx or origen.
<davepigott> liuyq: I'll find out
<zyga> liuyq, why did you move to kpartx?
<liuyq> zyga,  partx does not work on my precise, also not work on springz's natty
<zyga> liuyq, I see
<liuyq> zyga, but kparx works work for both
<zyga> liuyq, I'd prefer that to be a separate patch, and drop the # commented out version of partx
* zyga is not really in a position to tell this as I'm not a lava or validation person anymore
<zyga> but that's what I think
<davepigott> zyga: liuyq I completely agree about the commented out code, and we did say that you had to be on precise to make this work properly
<liuyq> zyga, thanks, I will delete the old partx comment when I merge. Here just for the convenience that if the kpartx does not work for all we can easily rollback
<zyga> davepigott, yes but apparently it's hard for some of the assignees to transition to new os release
 sure
 liuyq, I'd rather see a version that works on just kpartx than both comments, that'
 that's why we have bzr for
<davepigott> liuyq: The default rootfs size we set is 4G so it won't work on a 4G card
<liuyq> davepigott, yes, I told springz to specify the size with the command parameters
<liuyq> davepigott, zyga, BTW, we also have a lava-partition-disk under lava-dispatcher/doc/scripts/lava-partition-disk
<zyga> liuyq, oh, I'm happy to kill it if davepigott doesn't mind
<liuyq> davepigott, zyga, should we delete it? it seems almost the same as the one in lava-master-image-scripts, but a little out of date
<zyga> yes
<davepigott> +1

« Back to merge proposal