Code review comment for lp:~liuyq0307/lava-dispatcher/update-mount-partitions

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> schema.StringOption(default="/storage/sdcard0")
> > + possible_partitions_files = schema.StringOption(default="init.rc")
>
> I'm a little confused, isn't this something that is more likely to vary
> by build than by target board?
Yes, actually it varies by build, like ICS, JB, or others.
but will also varies by board because bhoj says that "we will be adding a cleanup to look at fstab.<ro.hardware> which would map to fstab.omap4pandaboard fstab.origen etc ."

and for us, we just need to list all the possible file there, and it will be OK I think.

« Back to merge proposal