Code review comment for lp:~liuyq0307/lava-dispatcher/update-mount-partitions

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> > + for f in possible_partitions_files:
> > + if session.is_file_exist(f):
> > + _update_uInitrd_partitions(session, f)
> > + # Will update the PS1 in init.rc in the following
> > + # So will not cat the file here
> > + if f != 'init.rc':
> > + session.run("cat %s" % f, failok=True)
> Why the conditional, seems like you should just print it out here and
> then delete the call below that always tries to cat it?
Like the comment just above the condition,
Here is a modification about the PS1 below, so keep the condition there.
Now I deleted the condition by moving the PS1 modification before this

> > session.run(
> > 'sed -i "/export PATH/a \ \ \ \ export PS1 \'%s\'" init.rc' %
> > target.ANDROID_TESTER_PS1)
> >
> > session.run("cat init.rc")
> > - session.run("cat init.partitions.rc", failok=True)
> Why are you keeping the call to "cat init.rc"?

« Back to merge proposal