Code review comment for lp:~liuyq0307/lava-android-test/workload

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> On 12/07/2012 11:13 AM, vishal wrote:
> > I get your point here. But the whole benchmark is written by ARM to run
> > over adb + they even take control of serial terminal similar to LAVA( we
> > don't execute that path but rely on LAVA to reboot etc).
>
> So use lava-android-test.
If this means you aggree this branch for now, please approve this MP.
>
> Its a little frustrating though:
>
> * Android guys complained for over a year about "no blackbox testing".
>
what I know about this is for the network test problem which the adb connection that lava-android-test relies on.
> * Benchmark guys complained about all Android results being invalid
> because of the same basic thing.
not know the details, but from the what I can guess it's not a problem lava can resolve,
normally benchmark tools only displayed the result with GUI where command tools are not able to get.
I don't think lava-test-shell can help on this, if it can do, I am glad to know how it implemented.

> We now have a solution in place, and you guys don't seem to be
> interested in using it.
Actually at least I am interesting in it,
but if you ask me to reimplement an existing tool which works well with adb connection,
then I will want to know why, and know how much time it will take to reimplement.

> >> >If you absolutely think I'm crazy, then continue with this approach, but
> >> >doing a "workload" test and requiring ADB seems like a bad idea.
> >> >
> > adb is used only to transfer the files before and after the benchmark is
> > run and not while the benchmark is running.
>
> So that could be done in lava-test-shell :)

« Back to merge proposal