Code review comment for lp:~liuyq0307/lava-android-test/sdcard-mounted

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> 50 + echo "Usage $0 [--serial|-s serial]"
>
> I'd say this is confusing/incorrect as both options can consume optional
> argument.
sorry, why you say that's confusing/incorrect?
by that I just want to say that we support both follow commands:
  sdcard-mounted.sh --serial serial
  sdcard-mounted.sh --s serial

And I just borrow this code from lava-partition-disk in lp:lava-master-image-scripts,
did not see the difference between the usage of them.:(

> In addition $0 is whatever was execed (which is fine) but it tends to be long
> (/usr/bin/foobar)
changed to use $(basename $0)

« Back to merge proposal