Code review comment for lp:~liuyq0307/lava-android-test/cts-update

Revision history for this message
Andy Doan (doanac) wrote :

A question on cts.py:

338 +RUN_STEPS_HOST_PRE = ['python %s/cts/cts_wrapper.py $(SERIAL)' % curdir]

The "python" command should work as expected in our old pip/virtualenv style deployment. Will this work in our new buildout style? In other words, when I run:

 . /srv/lava/instances/staging/bin/activate
 which python

I get "/usr/bin/python". I don't know for sure if this will pick up the lava-android-test python path. It via inheriting an envionrment from the parent process. You may want to double-check though.

Other wise, seems good.

« Back to merge proposal