Merge ~liushuyu-011/ubuntu/+source/tcpxtract:ubuntu/devel into ubuntu/+source/tcpxtract:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merged at revision: 528a69c7a438ddfb5a2f3ad7b9d890a9d72ca6ab
Proposed branch: ~liushuyu-011/ubuntu/+source/tcpxtract:ubuntu/devel
Merge into: ubuntu/+source/tcpxtract:ubuntu/devel
Diff against target: 87 lines (+65/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/70_fix-implicit-declarations.patch (+57/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Nick Rosbrook (community) Approve
Review via email: mp+464346@code.launchpad.net

Description of the change

This MP fixes the FTBFS issue on armhf due to missing includes and function prototypes.

To post a comment you must log in.
Revision history for this message
Zixing Liu (liushuyu-011) wrote :
Revision history for this message
Nick Rosbrook (enr0n) wrote :

LGTM. Sponsored.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 95caf6a..90e76d3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1tcpxtract (1.0.1-17ubuntu1) noble; urgency=medium
2
3 * debian/patches/70_fix-implicit-declarations.patch: Add missing
4 includes and function prototypes. Closes #1066484, LP: #2061589.
5
6 -- Zixing Liu <zixing.liu@canonical.com> Mon, 15 Apr 2024 10:41:14 -0600
7
1tcpxtract (1.0.1-17build2) noble; urgency=medium8tcpxtract (1.0.1-17build2) noble; urgency=medium
29
3 * No-change rebuild for CVE-2024-309410 * No-change rebuild for CVE-2024-3094
diff --git a/debian/patches/70_fix-implicit-declarations.patch b/debian/patches/70_fix-implicit-declarations.patch
4new file mode 10064411new file mode 100644
index 0000000..300762f
--- /dev/null
+++ b/debian/patches/70_fix-implicit-declarations.patch
@@ -0,0 +1,57 @@
1Description: Add missing includes and function prototypes
2 This fixes the FTBFS on armhf
3Author: Zixing Liu <zixing.liu@canonical.com>
4Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066484
5Bug-Ubuntu: https://bugs.launchpad.net/bugs/2061589
6Forwarded: no
7Last-Update: 2024-04-15
8---
9Index: tcpxtract/conf.h
10===================================================================
11--- tcpxtract.orig/conf.h
12+++ tcpxtract/conf.h
13@@ -24,5 +24,8 @@
14 #define CONF_H
15
16 extern void config_type(char *, char *, char *, char *);
17+int yyparse (void);
18+int yyerror(char *s);
19+int yylex (void);
20
21 #endif /* CONF_H */
22Index: tcpxtract/confl.l
23===================================================================
24--- tcpxtract.orig/confl.l
25+++ tcpxtract/confl.l
26@@ -20,6 +20,7 @@
27 Tcpxtract, a sniffer that extracts files based on headers
28 by Nick Harbour
29 */
30+#include <stdlib.h>
31 #include "confy.h"
32 %}
33
34Index: tcpxtract/confy.y
35===================================================================
36--- tcpxtract.orig/confy.y
37+++ tcpxtract/confy.y
38@@ -23,6 +23,7 @@
39
40 #include <stdlib.h>
41 #include "conf.h"
42+#include "confy.h"
43 %}
44
45 %union {
46Index: tcpxtract/tcpxtract.c
47===================================================================
48--- tcpxtract.orig/tcpxtract.c
49+++ tcpxtract/tcpxtract.c
50@@ -44,6 +44,7 @@
51
52 #include "sessionlist.h"
53 #include "util.h"
54+#include "conf.h"
55 #include "confy.h"
56 #include "search.h"
57
diff --git a/debian/patches/series b/debian/patches/series
index 4cca07f..4c8260e 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,3 +4,4 @@
440_fix-png-header-bytes.patch440_fix-png-header-bytes.patch
550_fix-spelling-binary.patch550_fix-spelling-binary.patch
660_libfl.patch660_libfl.patch
770_fix-implicit-declarations.patch

Subscribers

People subscribed via source and target branches

to all changes: