Merge ~liushuyu-011/ubuntu/+source/tcpxtract:ubuntu/devel into ubuntu/+source/tcpxtract:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merged at revision: 528a69c7a438ddfb5a2f3ad7b9d890a9d72ca6ab
Proposed branch: ~liushuyu-011/ubuntu/+source/tcpxtract:ubuntu/devel
Merge into: ubuntu/+source/tcpxtract:ubuntu/devel
Diff against target: 87 lines (+65/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/70_fix-implicit-declarations.patch (+57/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Nick Rosbrook (community) Approve
Review via email: mp+464346@code.launchpad.net

Description of the change

This MP fixes the FTBFS issue on armhf due to missing includes and function prototypes.

To post a comment you must log in.
Revision history for this message
Zixing Liu (liushuyu-011) wrote :
Revision history for this message
Nick Rosbrook (enr0n) wrote :

LGTM. Sponsored.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 95caf6a..90e76d3 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+tcpxtract (1.0.1-17ubuntu1) noble; urgency=medium
7+
8+ * debian/patches/70_fix-implicit-declarations.patch: Add missing
9+ includes and function prototypes. Closes #1066484, LP: #2061589.
10+
11+ -- Zixing Liu <zixing.liu@canonical.com> Mon, 15 Apr 2024 10:41:14 -0600
12+
13 tcpxtract (1.0.1-17build2) noble; urgency=medium
14
15 * No-change rebuild for CVE-2024-3094
16diff --git a/debian/patches/70_fix-implicit-declarations.patch b/debian/patches/70_fix-implicit-declarations.patch
17new file mode 100644
18index 0000000..300762f
19--- /dev/null
20+++ b/debian/patches/70_fix-implicit-declarations.patch
21@@ -0,0 +1,57 @@
22+Description: Add missing includes and function prototypes
23+ This fixes the FTBFS on armhf
24+Author: Zixing Liu <zixing.liu@canonical.com>
25+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066484
26+Bug-Ubuntu: https://bugs.launchpad.net/bugs/2061589
27+Forwarded: no
28+Last-Update: 2024-04-15
29+---
30+Index: tcpxtract/conf.h
31+===================================================================
32+--- tcpxtract.orig/conf.h
33++++ tcpxtract/conf.h
34+@@ -24,5 +24,8 @@
35+ #define CONF_H
36+
37+ extern void config_type(char *, char *, char *, char *);
38++int yyparse (void);
39++int yyerror(char *s);
40++int yylex (void);
41+
42+ #endif /* CONF_H */
43+Index: tcpxtract/confl.l
44+===================================================================
45+--- tcpxtract.orig/confl.l
46++++ tcpxtract/confl.l
47+@@ -20,6 +20,7 @@
48+ Tcpxtract, a sniffer that extracts files based on headers
49+ by Nick Harbour
50+ */
51++#include <stdlib.h>
52+ #include "confy.h"
53+ %}
54+
55+Index: tcpxtract/confy.y
56+===================================================================
57+--- tcpxtract.orig/confy.y
58++++ tcpxtract/confy.y
59+@@ -23,6 +23,7 @@
60+
61+ #include <stdlib.h>
62+ #include "conf.h"
63++#include "confy.h"
64+ %}
65+
66+ %union {
67+Index: tcpxtract/tcpxtract.c
68+===================================================================
69+--- tcpxtract.orig/tcpxtract.c
70++++ tcpxtract/tcpxtract.c
71+@@ -44,6 +44,7 @@
72+
73+ #include "sessionlist.h"
74+ #include "util.h"
75++#include "conf.h"
76+ #include "confy.h"
77+ #include "search.h"
78+
79diff --git a/debian/patches/series b/debian/patches/series
80index 4cca07f..4c8260e 100644
81--- a/debian/patches/series
82+++ b/debian/patches/series
83@@ -4,3 +4,4 @@
84 40_fix-png-header-bytes.patch
85 50_fix-spelling-binary.patch
86 60_libfl.patch
87+70_fix-implicit-declarations.patch

Subscribers

People subscribed via source and target branches

to all changes: