Merge ~liushuyu-011/ubuntu/+source/sleuthkit:ubuntu/devel into ubuntu/+source/sleuthkit:ubuntu/devel

Proposed by Zixing Liu
Status: Needs review
Proposed branch: ~liushuyu-011/ubuntu/+source/sleuthkit:ubuntu/devel
Merge into: ubuntu/+source/sleuthkit:ubuntu/devel
Diff against target: 58 lines (+24/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/70_off64_t-fix-on-32-bit-system.patch (+14/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Steve Langasek (community) Disapprove
Review via email: mp+462435@code.launchpad.net

Description of the change

This MP fixes the FTBFS by aliasing the off64_t to a type that is available on 32-bit systems after the time_t transition.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
Revision history for this message
Zixing Liu (liushuyu-011) :
Revision history for this message
Steve Langasek (vorlon) wrote :

sorry, my memory is short and over the course of a half hour I had forgotten that you were proposing a fix for this very package that LocutusOfBorg pinged about on IRC. We worked up a different fix which I think is more correct (don't define _LARGEFILE64_SOURCE in the source, that's just wrong).

Revision history for this message
Steve Langasek (vorlon) :
review: Disapprove

Unmerged commits

ef4c47d... by Zixing Liu

d/p/70_off64_t-fix-on-32-bit-system.patch: add a patch to fix build ...

... on 32-bit systems after time_t transition

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 4f06c12..18481ac 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1sleuthkit (4.12.1+dfsg-1.1ubuntu1) noble; urgency=medium
2
3 * d/p/70_off64_t-fix-on-32-bit-system.patch: add a patch so that 64-bit
4 file offsets are properly used on 32-bit systems
5
6 -- Zixing Liu <zixing.liu@canonical.com> Thu, 14 Mar 2024 09:18:15 -0600
7
1sleuthkit (4.12.1+dfsg-1.1) unstable; urgency=medium8sleuthkit (4.12.1+dfsg-1.1) unstable; urgency=medium
29
3 * Non-maintainer upload.10 * Non-maintainer upload.
diff --git a/debian/control b/debian/control
index 9c41540..3e05ba5 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
1Source: sleuthkit1Source: sleuthkit
2Section: admin2Section: admin
3Priority: optional3Priority: optional
4Maintainer: Debian Security Tools <team+pkg-security@tracker.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian Security Tools <team+pkg-security@tracker.debian.org>
5Build-Depends: dpkg-dev (>= 1.22.5), ant,6Build-Depends: dpkg-dev (>= 1.22.5), ant,
6 debhelper-compat (= 13),7 debhelper-compat (= 13),
7 libafflib-dev (>= 3.6.6),8 libafflib-dev (>= 3.6.6),
diff --git a/debian/patches/70_off64_t-fix-on-32-bit-system.patch b/debian/patches/70_off64_t-fix-on-32-bit-system.patch
8new file mode 1006449new file mode 100644
index 0000000..33c40e5
--- /dev/null
+++ b/debian/patches/70_off64_t-fix-on-32-bit-system.patch
@@ -0,0 +1,14 @@
1Description: Fix large file offset usage on 32-bit systems
2 This patch aliases off64_t to __off64_t on 32-bit systems where off64_t
3 is not available.
4Forwarded: not-needed
5Last-Update: 2024-03-14
6
7--- sleuthkit-4.12.1+dfsg.orig/tsk/fs/Makefile.am
8+++ sleuthkit-4.12.1+dfsg/tsk/fs/Makefile.am
9@@ -1,4 +1,4 @@
10-AM_CPPFLAGS = $(OPENSSL_INCLUDES) -I../.. -I$(srcdir)/../..
11+AM_CPPFLAGS = $(OPENSSL_INCLUDES) -I../.. -I$(srcdir)/../.. -Doff64_t=__off64_t
12 EXTRA_DIST = .indent.pro
13
14 noinst_LTLIBRARIES = libtskfs.la
diff --git a/debian/patches/series b/debian/patches/series
index 32375aa..19b0ef1 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,3 +4,4 @@
460_fix-FTBFS-HURD.patch460_fix-FTBFS-HURD.patch
50005-Disable-test_libraries.sh.patch50005-Disable-test_libraries.sh.patch
66
770_off64_t-fix-on-32-bit-system.patch

Subscribers

People subscribed via source and target branches

to all changes: