Merge ~liushuyu-011/ubuntu/+source/sleuthkit:ubuntu/devel into ubuntu/+source/sleuthkit:ubuntu/devel

Proposed by Zixing Liu
Status: Needs review
Proposed branch: ~liushuyu-011/ubuntu/+source/sleuthkit:ubuntu/devel
Merge into: ubuntu/+source/sleuthkit:ubuntu/devel
Diff against target: 58 lines (+24/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/70_off64_t-fix-on-32-bit-system.patch (+14/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Steve Langasek (community) Disapprove
Review via email: mp+462435@code.launchpad.net

Description of the change

This MP fixes the FTBFS by aliasing the off64_t to a type that is available on 32-bit systems after the time_t transition.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Needs Information
Revision history for this message
Zixing Liu (liushuyu-011) :
Revision history for this message
Steve Langasek (vorlon) wrote :

sorry, my memory is short and over the course of a half hour I had forgotten that you were proposing a fix for this very package that LocutusOfBorg pinged about on IRC. We worked up a different fix which I think is more correct (don't define _LARGEFILE64_SOURCE in the source, that's just wrong).

Revision history for this message
Steve Langasek (vorlon) :
review: Disapprove

Unmerged commits

ef4c47d... by Zixing Liu

d/p/70_off64_t-fix-on-32-bit-system.patch: add a patch to fix build ...

... on 32-bit systems after time_t transition

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4f06c12..18481ac 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+sleuthkit (4.12.1+dfsg-1.1ubuntu1) noble; urgency=medium
7+
8+ * d/p/70_off64_t-fix-on-32-bit-system.patch: add a patch so that 64-bit
9+ file offsets are properly used on 32-bit systems
10+
11+ -- Zixing Liu <zixing.liu@canonical.com> Thu, 14 Mar 2024 09:18:15 -0600
12+
13 sleuthkit (4.12.1+dfsg-1.1) unstable; urgency=medium
14
15 * Non-maintainer upload.
16diff --git a/debian/control b/debian/control
17index 9c41540..3e05ba5 100644
18--- a/debian/control
19+++ b/debian/control
20@@ -1,7 +1,8 @@
21 Source: sleuthkit
22 Section: admin
23 Priority: optional
24-Maintainer: Debian Security Tools <team+pkg-security@tracker.debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian Security Tools <team+pkg-security@tracker.debian.org>
27 Build-Depends: dpkg-dev (>= 1.22.5), ant,
28 debhelper-compat (= 13),
29 libafflib-dev (>= 3.6.6),
30diff --git a/debian/patches/70_off64_t-fix-on-32-bit-system.patch b/debian/patches/70_off64_t-fix-on-32-bit-system.patch
31new file mode 100644
32index 0000000..33c40e5
33--- /dev/null
34+++ b/debian/patches/70_off64_t-fix-on-32-bit-system.patch
35@@ -0,0 +1,14 @@
36+Description: Fix large file offset usage on 32-bit systems
37+ This patch aliases off64_t to __off64_t on 32-bit systems where off64_t
38+ is not available.
39+Forwarded: not-needed
40+Last-Update: 2024-03-14
41+
42+--- sleuthkit-4.12.1+dfsg.orig/tsk/fs/Makefile.am
43++++ sleuthkit-4.12.1+dfsg/tsk/fs/Makefile.am
44+@@ -1,4 +1,4 @@
45+-AM_CPPFLAGS = $(OPENSSL_INCLUDES) -I../.. -I$(srcdir)/../..
46++AM_CPPFLAGS = $(OPENSSL_INCLUDES) -I../.. -I$(srcdir)/../.. -Doff64_t=__off64_t
47+ EXTRA_DIST = .indent.pro
48+
49+ noinst_LTLIBRARIES = libtskfs.la
50diff --git a/debian/patches/series b/debian/patches/series
51index 32375aa..19b0ef1 100644
52--- a/debian/patches/series
53+++ b/debian/patches/series
54@@ -4,3 +4,4 @@
55 60_fix-FTBFS-HURD.patch
56 0005-Disable-test_libraries.sh.patch
57
58+70_off64_t-fix-on-32-bit-system.patch

Subscribers

People subscribed via source and target branches

to all changes: