Merge ~liushuyu-011/ubuntu/+source/netdiag:ubuntu/devel into ubuntu/+source/netdiag:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merged at revision: d45ccb43a7c9c17456855622991ce60b7cfa93b7
Proposed branch: ~liushuyu-011/ubuntu/+source/netdiag:ubuntu/devel
Merge into: ubuntu/+source/netdiag:ubuntu/devel
Diff against target: 136 lines (+114/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/gcc13.patch (+106/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Vladimir Petko (community) Approve
Review via email: mp+464074@code.launchpad.net

Description of the change

This MP adds a patch to fix FTBFS on armhf due to various instances of missing headers and missing prototypes.

To post a comment you must log in.
Revision history for this message
Zixing Liu (liushuyu-011) wrote :
Revision history for this message
Vladimir Petko (vpa1977) wrote :

a couple of minor nits, but nothing blocking.

review: Approve
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Uploaded, thank you!!!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index b4e23ee..d25883d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
1netdiag (1.2-1.2ubuntu1) noble; urgency=medium
2
3 * debian/patches/gcc13.patch: Add multiple missing headers and
4 function prototypes. Closes LP: #2060901.
5
6 -- Zixing Liu <zixing.liu@canonical.com> Wed, 10 Apr 2024 21:26:00 -0600
7
1netdiag (1.2-1.2build2) noble; urgency=medium8netdiag (1.2-1.2build2) noble; urgency=medium
29
3 * No-change rebuild for CVE-2024-309410 * No-change rebuild for CVE-2024-3094
diff --git a/debian/patches/gcc13.patch b/debian/patches/gcc13.patch
4new file mode 10064411new file mode 100644
index 0000000..63ac846
--- /dev/null
+++ b/debian/patches/gcc13.patch
@@ -0,0 +1,106 @@
1Description: Add multiple missing headers and function prototypes
2Author: Zixing Liu <zixing.liu@canonical.com>
3Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066694
4Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/netdiag/+bug/2060901
5Forwarded: no
6Last-Update: 2024-04-10
7Index: netdiag/netwatch-1.3.1-2/netwatch.h
8===================================================================
9--- netdiag.orig/netwatch-1.3.1-2/netwatch.h
10+++ netdiag/netwatch-1.3.1-2/netwatch.h
11@@ -38,6 +38,10 @@
12 #define SN_PROT_LOOP 164 /* Pseudo protocol for Loopback */
13
14 #include <sys/types.h>
15+#include <time.h>
16+#include <ctype.h>
17+#include <unistd.h>
18+#include <stdlib.h>
19 #include "config.h"
20 /*
21 #ifdef NETINET_SUPP_socket
22@@ -84,6 +88,11 @@ typedef unsigned short sa_family_t;
23
24
25 #include "core.h"
26+int dokeyin(int force);
27+int doeth();
28+int gh (int opt);
29+void setuphelp();
30+void uthread_wait(long usec);
31 void dispdata(int errnum);
32 void services();
33 void usage(char *arg);
34Index: netdiag/statnet-3.8/statnet.c
35===================================================================
36--- netdiag.orig/statnet-3.8/statnet.c
37+++ netdiag/statnet-3.8/statnet.c
38@@ -7,7 +7,6 @@
39 #define MAIN_LINE 1
40
41 #include <values.h>
42-#include "stat.h"
43
44 #include "curs.h"
45 #include <signal.h>
46@@ -33,6 +32,8 @@
47 #endif
48
49 #include <sys/shm.h>
50+#include <curses.h>
51+#include "stat.h"
52
53 #define Stringify(X) #X
54 #define Quoteify(X) Stringify(X)
55Index: netdiag/statnet-3.8/getservent.c
56===================================================================
57--- netdiag.orig/statnet-3.8/getservent.c
58+++ netdiag/statnet-3.8/getservent.c
59@@ -43,7 +43,7 @@ static char sccsid[] = "@(#)getservent.c
60 #endif /* LIBC_SCCS and not lint */
61
62 #include "inetprivate.h"
63-
64+#include <stdlib.h>
65 #define MAXALIASES 35
66
67 static char SERVDB[] = _PATH_SERVICES;
68Index: netdiag/statnet-3.8/itstime.c
69===================================================================
70--- netdiag.orig/statnet-3.8/itstime.c
71+++ netdiag/statnet-3.8/itstime.c
72@@ -8,7 +8,7 @@
73 #include "stat.h"
74 #include <errno.h>
75 #include <signal.h>
76-
77+#include <unistd.h>
78 extern struct StatMemStruct *StatMem; /* pointer to shared memory segment */
79
80 void itstime (int errnum)
81Index: netdiag/statnet-3.8/stat.h
82===================================================================
83--- netdiag.orig/statnet-3.8/stat.h
84+++ netdiag/statnet-3.8/stat.h
85@@ -197,7 +197,7 @@ void set_null ( struct StatMemStruct *St
86 void services ();
87 void stat_delta ( struct StatMemStruct *New, struct StatMemStruct *Prev, struct StatMemStruct *Delta );
88 void usage (char *arg);
89-#ifdef WINDOW
90+#if CURSES_H
91 void win_show_stat( WINDOW *win, int X, int Y, int noframes, struct Tally *Now_ts, struct Tally *Prev_ts, struct Tally *Delta_ts, short rewrite_labels, short *update_labels, void *show_labels );
92 #endif
93
94@@ -226,10 +226,10 @@ void tally_ntoh ( int bytecode,
95 struct Tally *New_t,
96 struct Tally *Prev_t );
97
98-#ifdef WINDOW
99+#if CURSES_H
100 void tally_label ( struct Tally *Now_ts, WINDOW *win, int width, int height );
101 #endif
102-
103+int tally (int type_wanted, struct Tally *tally);
104
105 /* Now some redefinitions of <netdb.h> stuff. With the Berkeley notice... */
106
diff --git a/debian/patches/series b/debian/patches/series
index 2e4ffbe..db294ad 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -9,3 +9,4 @@ clang-ftbfs.diff
9gcc-10.diff9gcc-10.diff
10pcap_init.diff10pcap_init.diff
11gcc12.patch11gcc12.patch
12gcc13.patch

Subscribers

People subscribed via source and target branches

to all changes: