Merge ~liushuyu-011/ubuntu/+source/netdiag:ubuntu/devel into ubuntu/+source/netdiag:ubuntu/devel

Proposed by Zixing Liu
Status: Merged
Merged at revision: d45ccb43a7c9c17456855622991ce60b7cfa93b7
Proposed branch: ~liushuyu-011/ubuntu/+source/netdiag:ubuntu/devel
Merge into: ubuntu/+source/netdiag:ubuntu/devel
Diff against target: 136 lines (+114/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/gcc13.patch (+106/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Vladimir Petko (community) Approve
Review via email: mp+464074@code.launchpad.net

Description of the change

This MP adds a patch to fix FTBFS on armhf due to various instances of missing headers and missing prototypes.

To post a comment you must log in.
Revision history for this message
Zixing Liu (liushuyu-011) wrote :
Revision history for this message
Vladimir Petko (vpa1977) wrote :

a couple of minor nits, but nothing blocking.

review: Approve
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Uploaded, thank you!!!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index b4e23ee..d25883d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+netdiag (1.2-1.2ubuntu1) noble; urgency=medium
7+
8+ * debian/patches/gcc13.patch: Add multiple missing headers and
9+ function prototypes. Closes LP: #2060901.
10+
11+ -- Zixing Liu <zixing.liu@canonical.com> Wed, 10 Apr 2024 21:26:00 -0600
12+
13 netdiag (1.2-1.2build2) noble; urgency=medium
14
15 * No-change rebuild for CVE-2024-3094
16diff --git a/debian/patches/gcc13.patch b/debian/patches/gcc13.patch
17new file mode 100644
18index 0000000..63ac846
19--- /dev/null
20+++ b/debian/patches/gcc13.patch
21@@ -0,0 +1,106 @@
22+Description: Add multiple missing headers and function prototypes
23+Author: Zixing Liu <zixing.liu@canonical.com>
24+Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066694
25+Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/netdiag/+bug/2060901
26+Forwarded: no
27+Last-Update: 2024-04-10
28+Index: netdiag/netwatch-1.3.1-2/netwatch.h
29+===================================================================
30+--- netdiag.orig/netwatch-1.3.1-2/netwatch.h
31++++ netdiag/netwatch-1.3.1-2/netwatch.h
32+@@ -38,6 +38,10 @@
33+ #define SN_PROT_LOOP 164 /* Pseudo protocol for Loopback */
34+
35+ #include <sys/types.h>
36++#include <time.h>
37++#include <ctype.h>
38++#include <unistd.h>
39++#include <stdlib.h>
40+ #include "config.h"
41+ /*
42+ #ifdef NETINET_SUPP_socket
43+@@ -84,6 +88,11 @@ typedef unsigned short sa_family_t;
44+
45+
46+ #include "core.h"
47++int dokeyin(int force);
48++int doeth();
49++int gh (int opt);
50++void setuphelp();
51++void uthread_wait(long usec);
52+ void dispdata(int errnum);
53+ void services();
54+ void usage(char *arg);
55+Index: netdiag/statnet-3.8/statnet.c
56+===================================================================
57+--- netdiag.orig/statnet-3.8/statnet.c
58++++ netdiag/statnet-3.8/statnet.c
59+@@ -7,7 +7,6 @@
60+ #define MAIN_LINE 1
61+
62+ #include <values.h>
63+-#include "stat.h"
64+
65+ #include "curs.h"
66+ #include <signal.h>
67+@@ -33,6 +32,8 @@
68+ #endif
69+
70+ #include <sys/shm.h>
71++#include <curses.h>
72++#include "stat.h"
73+
74+ #define Stringify(X) #X
75+ #define Quoteify(X) Stringify(X)
76+Index: netdiag/statnet-3.8/getservent.c
77+===================================================================
78+--- netdiag.orig/statnet-3.8/getservent.c
79++++ netdiag/statnet-3.8/getservent.c
80+@@ -43,7 +43,7 @@ static char sccsid[] = "@(#)getservent.c
81+ #endif /* LIBC_SCCS and not lint */
82+
83+ #include "inetprivate.h"
84+-
85++#include <stdlib.h>
86+ #define MAXALIASES 35
87+
88+ static char SERVDB[] = _PATH_SERVICES;
89+Index: netdiag/statnet-3.8/itstime.c
90+===================================================================
91+--- netdiag.orig/statnet-3.8/itstime.c
92++++ netdiag/statnet-3.8/itstime.c
93+@@ -8,7 +8,7 @@
94+ #include "stat.h"
95+ #include <errno.h>
96+ #include <signal.h>
97+-
98++#include <unistd.h>
99+ extern struct StatMemStruct *StatMem; /* pointer to shared memory segment */
100+
101+ void itstime (int errnum)
102+Index: netdiag/statnet-3.8/stat.h
103+===================================================================
104+--- netdiag.orig/statnet-3.8/stat.h
105++++ netdiag/statnet-3.8/stat.h
106+@@ -197,7 +197,7 @@ void set_null ( struct StatMemStruct *St
107+ void services ();
108+ void stat_delta ( struct StatMemStruct *New, struct StatMemStruct *Prev, struct StatMemStruct *Delta );
109+ void usage (char *arg);
110+-#ifdef WINDOW
111++#if CURSES_H
112+ void win_show_stat( WINDOW *win, int X, int Y, int noframes, struct Tally *Now_ts, struct Tally *Prev_ts, struct Tally *Delta_ts, short rewrite_labels, short *update_labels, void *show_labels );
113+ #endif
114+
115+@@ -226,10 +226,10 @@ void tally_ntoh ( int bytecode,
116+ struct Tally *New_t,
117+ struct Tally *Prev_t );
118+
119+-#ifdef WINDOW
120++#if CURSES_H
121+ void tally_label ( struct Tally *Now_ts, WINDOW *win, int width, int height );
122+ #endif
123+-
124++int tally (int type_wanted, struct Tally *tally);
125+
126+ /* Now some redefinitions of <netdb.h> stuff. With the Berkeley notice... */
127+
128diff --git a/debian/patches/series b/debian/patches/series
129index 2e4ffbe..db294ad 100644
130--- a/debian/patches/series
131+++ b/debian/patches/series
132@@ -9,3 +9,4 @@ clang-ftbfs.diff
133 gcc-10.diff
134 pcap_init.diff
135 gcc12.patch
136+gcc13.patch

Subscribers

People subscribed via source and target branches

to all changes: