Code review comment for ~litios/ubuntu-cve-tracker:eol-tags-update
Revision history for this message
| Paulo Flabiano Smorigo (pfsmorigo) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
7020100
(Get the code!)
All changes are fine. Thanks for doing it. One small comment is that I saw two scripts in $UCT/scripts that still uses "out of standard support": check-syntax-fixup and esm-syntax. Can you also fix those? Not sure if there are still used tho.
About the testing, maybe we can use your testing scenarios as the base to include pytests for active_edit in $UCT/tests. Not in this PR, this a future plan!