Code review comment for ~litios/ubuntu-cve-tracker:sync-from-usns-extract-cves

Revision history for this message
Spyros Seimenis (sespiros) wrote :

Hi David, thanks for the changes and the tests! I think overall it reads much better now. A couple of final comments inline.

- (nitpick) you could tighten the CVE regex to CVE-\d{4}-\d{4,7}
- (nitpick) cve_list maybe would read better than cves_chunk as a variable name

Also it seems that the CI tests are failing, not sure if it's because of this or transient error, you can run these locally with

sudo snap install --classic lpci
cd $UCT
lpci

« Back to merge proposal