Merge ~litios/ubuntu-cve-tracker:sync-usns-esm into ubuntu-cve-tracker:master

Proposed by David Fernandez Gonzalez
Status: Merged
Merged at revision: 5048522b86411d5b592464cc257fe6f0d0ce66c5
Proposed branch: ~litios/ubuntu-cve-tracker:sync-usns-esm
Merge into: ubuntu-cve-tracker:master
Diff against target: 44 lines (+17/-2)
1 file modified
scripts/sync-from-usns.py (+17/-2)
Reviewer Review Type Date Requested Status
Eduardo Barretto Approve
Review via email: mp+440853@code.launchpad.net

Description of the change

When syncing from a USN, if an update was done for a regular release, we should update the ESM status accordingly, as ESM won't be affected anymore.

Testing: https://pastebin.canonical.com/p/tmFCjMGfBD/

To post a comment you must log in.
Revision history for this message
Eduardo Barretto (ebarretto) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/scripts/sync-from-usns.py b/scripts/sync-from-usns.py
index eae30da..ee138b5 100755
--- a/scripts/sync-from-usns.py
+++ b/scripts/sync-from-usns.py
@@ -123,7 +123,7 @@ def extract_cve_descriptions(usn, usnnum):
123123
124 return descriptions124 return descriptions
125125
126126srcmap = {}
127for usn in usnlist:127for usn in usnlist:
128 ubuntu_descriptions = dict()128 ubuntu_descriptions = dict()
129 if args.debug:129 if args.debug:
@@ -239,7 +239,8 @@ for usn in usnlist:
239 if cve_lib.is_active_release(rel):239 if cve_lib.is_active_release(rel):
240 cve_rel = cve_lib.get_esm_name(rel, 'universe')240 cve_rel = cve_lib.get_esm_name(rel, 'universe')
241 else:241 else:
242 srcmap = load(releases=[rel], skip_eol_releases=False)242 if not rel in srcmap:
243 srcmap[rel] = load(releases=[rel], skip_eol_releases=False)[rel]
243 if cve_lib.is_universe(srcmap, src, rel, None):244 if cve_lib.is_universe(srcmap, src, rel, None):
244 cve_rel = cve_lib.get_esm_name(rel, 'universe')245 cve_rel = cve_lib.get_esm_name(rel, 'universe')
245 else:246 else:
@@ -309,6 +310,20 @@ for usn in usnlist:
309 version = usn_ver310 version = usn_ver
310 if args.update:311 if args.update:
311 cve_lib.update_state(filename, src, cve_rel, 'released', version)312 cve_lib.update_state(filename, src, cve_rel, 'released', version)
313
314 if esm_version_match:
315 continue
316
317 if not cve_rel in srcmap:
318 srcmap[cve_rel] = load(releases=[cve_rel], skip_eol_releases=False)[cve_rel]
319
320 esm_rel = cve_lib.get_esm_name(cve_rel, 'universe' if cve_lib.is_universe(srcmap, src, cve_rel, None) else 'main')
321 if esm_rel and esm_rel in cves[cve]['pkgs'][src]:
322 status_esm = cves[cve]['pkgs'][src][esm_rel][0]
323 if status_esm != 'released' and status_esm != 'not-affected' and status_esm != 'ignored':
324 print("USN-%s fixed %s in %s %s%s/%s (was %s)" % (usn, cve, src, version, detail, esm_rel, status_esm), file=sys.stderr)
325 cve_lib.update_state(filename, src, esm_rel, 'not-affected', version)
326
312 if args.git_stage:327 if args.git_stage:
313 cve_lib.git_add(filename)328 cve_lib.git_add(filename)
314 elif args.debug:329 elif args.debug:

Subscribers

People subscribed via source and target branches