Merge lp:~linuxjedi/libdrizzle/5.1-query into lp:libdrizzle

Proposed by Andrew Hutchings
Status: Merged
Approved by: Andrew Hutchings
Approved revision: 86
Merged at revision: 86
Proposed branch: lp:~linuxjedi/libdrizzle/5.1-query
Merge into: lp:libdrizzle
Diff against target: 486 lines (+57/-87)
14 files modified
docs/api/query.rst (+1/-11)
docs/examples/buffered.rst (+2/-2)
docs/examples/unbuffered.rst (+2/-2)
libdrizzle-5.1/query.h (+0/-8)
libdrizzle/binlog.cc (+1/-1)
libdrizzle/query.cc (+2/-14)
tests/unit/column.c (+7/-7)
tests/unit/connect.c (+2/-2)
tests/unit/insert_id.c (+7/-7)
tests/unit/query.c (+7/-7)
tests/unit/row.c (+7/-7)
tests/unit/statement.c (+6/-6)
tests/unit/statement_char.c (+6/-6)
tests/unit/unbuffered_query.c (+7/-7)
To merge this branch: bzr merge lp:~linuxjedi/libdrizzle/5.1-query
Reviewer Review Type Date Requested Status
Drizzle Trunk Pending
Review via email: mp+142799@code.launchpad.net

Description of the change

Removes drizzle_query_str and make drizzle_query with a 0 string length do the same thing.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'docs/api/query.rst'
--- docs/api/query.rst 2013-01-05 10:27:32 +0000
+++ docs/api/query.rst 2013-01-10 22:17:22 +0000
@@ -27,17 +27,7 @@
2727
28 :param con: A connection object28 :param con: A connection object
29 :param query: The query to execute29 :param query: The query to execute
30 :param size: The length of the query string30 :param size: The length of the query string, if set to 0 then :c:func:`strlen` is used to calculate the length
31 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into
32 :returns: A newly allocated result object
33
34.. c:function:: drizzle_result_st* drizzle_query_str(drizzle_st *con, const char *query, drizzle_return_t *ret_ptr)
35
36 Executes a query using :c:func:`strlen` to calculate the length of the query
37 string and returns a newly allocated result struct
38
39 :param con: A connection object
40 :param query: The query to execute
41 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into31 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into
42 :returns: A newly allocated result object32 :returns: A newly allocated result object
4333
4434
=== modified file 'docs/examples/buffered.rst'
--- docs/examples/buffered.rst 2012-12-24 10:20:04 +0000
+++ docs/examples/buffered.rst 2013-01-10 22:17:22 +0000
@@ -4,7 +4,7 @@
4Introduction4Introduction
5------------5------------
66
7In this example :c:func:`drizzle_query_str` is used to send a select query to a7In this example :c:func:`drizzle_query` is used to send a select query to a
8MySQL server. The whole result set is then retrieved and stored in memory8MySQL server. The whole result set is then retrieved and stored in memory
9using :c:func:`drizzle_result_buffer`.9using :c:func:`drizzle_result_buffer`.
1010
@@ -49,7 +49,7 @@
49 return EXIT_FAILURE;49 return EXIT_FAILURE;
50 }50 }
5151
52 result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);52 result= drizzle_query(con, "select * from libdrizzle.t1", 0, &ret);
53 if (ret != DRIZZLE_RETURN_OK)53 if (ret != DRIZZLE_RETURN_OK)
54 {54 {
55 printf("Select failure\n");55 printf("Select failure\n");
5656
=== modified file 'docs/examples/unbuffered.rst'
--- docs/examples/unbuffered.rst 2012-12-24 10:20:04 +0000
+++ docs/examples/unbuffered.rst 2013-01-10 22:17:22 +0000
@@ -4,7 +4,7 @@
4Introduction4Introduction
5------------5------------
66
7In this example :c:func:`drizzle_query_str` is used to send a select query to a7In this example :c:func:`drizzle_query` is used to send a select query to a
8MySQL server. The first thing that is sent back in the results is a list of8MySQL server. The first thing that is sent back in the results is a list of
9columns, so this list needs to be retieved. The simplist way of doing this is9columns, so this list needs to be retieved. The simplist way of doing this is
10to buffer the column data using :c:func:`drizzle_column_buffer`.10to buffer the column data using :c:func:`drizzle_column_buffer`.
@@ -51,7 +51,7 @@
51 return EXIT_FAILURE;51 return EXIT_FAILURE;
52 }52 }
5353
54 result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);54 result= drizzle_query(con, "select * from libdrizzle.t1", 0, &ret);
55 if (ret != DRIZZLE_RETURN_OK)55 if (ret != DRIZZLE_RETURN_OK)
56 {56 {
57 printf("Select failure\n");57 printf("Select failure\n");
5858
=== modified file 'libdrizzle-5.1/query.h'
--- libdrizzle-5.1/query.h 2013-01-05 10:27:32 +0000
+++ libdrizzle-5.1/query.h 2013-01-10 22:17:22 +0000
@@ -73,14 +73,6 @@
73 const char *query, size_t size,73 const char *query, size_t size,
74 drizzle_return_t *ret_ptr);74 drizzle_return_t *ret_ptr);
7575
76/**
77 * Send query to server, using strlen to get the size of query buffer..
78 */
79DRIZZLE_API
80drizzle_result_st *drizzle_query_str(drizzle_st *con,
81 const char *query,
82 drizzle_return_t *ret_ptr);
83
84/*76/*
85 * Escape a string or encode a string in hexadecimal. The return value is the77 * Escape a string or encode a string in hexadecimal. The return value is the
86 * size of the output string in to.78 * size of the output string in to.
8779
=== modified file 'libdrizzle/binlog.cc'
--- libdrizzle/binlog.cc 2013-01-05 15:56:07 +0000
+++ libdrizzle/binlog.cc 2013-01-10 22:17:22 +0000
@@ -52,7 +52,7 @@
52 drizzle_result_st *result;52 drizzle_result_st *result;
5353
54 // Hack in 5.6 to say that client support checksums54 // Hack in 5.6 to say that client support checksums
55 result= drizzle_query_str(con, "SET @master_binlog_checksum='NONE'", ret_ptr);55 result= drizzle_query(con, "SET @master_binlog_checksum='NONE'", 0, ret_ptr);
56 drizzle_result_free(result);56 drizzle_result_free(result);
57 if (*ret_ptr != DRIZZLE_RETURN_OK)57 if (*ret_ptr != DRIZZLE_RETURN_OK)
58 {58 {
5959
=== modified file 'libdrizzle/query.cc'
--- libdrizzle/query.cc 2013-01-05 15:56:07 +0000
+++ libdrizzle/query.cc 2013-01-10 22:17:22 +0000
@@ -48,26 +48,14 @@
48 const char *query, size_t size,48 const char *query, size_t size,
49 drizzle_return_t *ret_ptr)49 drizzle_return_t *ret_ptr)
50{50{
51 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_QUERY,51 if (size == 0)
52 (unsigned char *)query, size, size, ret_ptr);
53}
54
55drizzle_result_st *drizzle_query_str(drizzle_st *con,
56 const char *query,
57 drizzle_return_t *ret_ptr)
58{
59 if (query == NULL)
60 {52 {
61 return NULL;53 size= strlen(query);
62 }54 }
63
64 size_t size= strlen(query);
65
66 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_QUERY,55 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_QUERY,
67 (unsigned char *)query, size, size, ret_ptr);56 (unsigned char *)query, size, size, ret_ptr);
68}57}
6958
70
71ssize_t drizzle_escape_string(char *to, const size_t max_to_size, const char *from, const size_t from_size)59ssize_t drizzle_escape_string(char *to, const size_t max_to_size, const char *from, const size_t from_size)
72{60{
73 const char *end;61 const char *end;
7462
=== modified file 'tests/unit/column.c'
--- tests/unit/column.c 2013-01-05 11:41:26 +0000
+++ tests/unit/column.c 2013-01-10 22:17:22 +0000
@@ -65,22 +65,22 @@
65 }65 }
66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s(%s)", drizzle_error(con), strerror(ret));66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s(%s)", drizzle_error(con), strerror(ret));
6767
68 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);68 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7070
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query(con, "CREATE SCHEMA libdrizzle", 0, &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 ret= drizzle_select_db(con, "libdrizzle");74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int primary key auto_increment, b varchar(255), c timestamp default current_timestamp)", &ret);77 drizzle_query(con, "create table libdrizzle.t1 (a int primary key auto_increment, b varchar(255), c timestamp default current_timestamp)", 0, &ret);
78 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "create table libdrizzle.t1 (a int primary key auto_increment, b varchar(255), c timestamp default current_timestamp)");78 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "create table libdrizzle.t1 (a int primary key auto_increment, b varchar(255), c timestamp default current_timestamp)");
7979
80 drizzle_query_str(con, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')", &ret);80 drizzle_query(con, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')", 0, &ret);
81 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')");81 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')");
8282
83 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);83 drizzle_result_st *result= drizzle_query(con, "select * from libdrizzle.t1", 0, &ret);
84 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "select * from libdrizzle.t1");84 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "select * from libdrizzle.t1");
8585
86 drizzle_result_buffer(result);86 drizzle_result_buffer(result);
@@ -115,10 +115,10 @@
115115
116 drizzle_result_free(result);116 drizzle_result_free(result);
117117
118 drizzle_query_str(con, "DROP TABLE libdrizzle.t1", &ret);118 drizzle_query(con, "DROP TABLE libdrizzle.t1", 0, &ret);
119 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");119 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");
120120
121 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);121 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
122 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));122 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));
123123
124 ret= drizzle_quit(con);124 ret= drizzle_quit(con);
125125
=== modified file 'tests/unit/connect.c'
--- tests/unit/connect.c 2012-12-31 00:06:53 +0000
+++ tests/unit/connect.c 2013-01-10 22:17:22 +0000
@@ -63,7 +63,7 @@
63 }63 }
64 ASSERT_EQ(DRIZZLE_RETURN_OK, ret);64 ASSERT_EQ(DRIZZLE_RETURN_OK, ret);
6565
66 drizzle_query_str(con, "SELECT 1", &ret);66 drizzle_query(con, "SELECT 1", 0, &ret);
67 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "SELECT 1 (%s)", drizzle_error(con));67 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "SELECT 1 (%s)", drizzle_error(con));
6868
69 // Now that we know everything is good... lets push it.69 // Now that we know everything is good... lets push it.
@@ -75,7 +75,7 @@
75 ret= drizzle_connect(con);75 ret= drizzle_connect(con);
76 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s(%s)", drizzle_error(con), drizzle_strerror(ret));76 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s(%s)", drizzle_error(con), drizzle_strerror(ret));
7777
78 drizzle_query_str(con, "SELECT 1", &ret);78 drizzle_query(con, "SELECT 1", 0, &ret);
79 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "SELECT 1 (%s)", drizzle_error(con));79 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "SELECT 1 (%s)", drizzle_error(con));
8080
81 // Now that we know everything is good... lets push it.81 // Now that we know everything is good... lets push it.
8282
=== modified file 'tests/unit/insert_id.c'
--- tests/unit/insert_id.c 2013-01-05 11:41:26 +0000
+++ tests/unit/insert_id.c 2013-01-10 22:17:22 +0000
@@ -64,35 +64,35 @@
64 }64 }
65 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s", drizzle_error(con));65 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s", drizzle_error(con));
6666
67 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);67 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
68 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));68 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
6969
70 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);70 drizzle_query(con, "CREATE SCHEMA libdrizzle", 0, &ret);
71 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));71 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7272
73 ret= drizzle_select_db(con, "libdrizzle");73 ret= drizzle_select_db(con, "libdrizzle");
74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7575
76 drizzle_query_str(con, "create table libdrizzle.t1 (a int primary key auto_increment, b int)", &ret);76 drizzle_query(con, "create table libdrizzle.t1 (a int primary key auto_increment, b int)", 0, &ret);
77 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "create table libdrizzle.t1 (a int primary key auto_increment, b int)");77 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "create table libdrizzle.t1 (a int primary key auto_increment, b int)");
7878
79 drizzle_result_st *result= drizzle_query_str(con, "insert into libdrizzle.t1 (b) values (1),(2),(3)", &ret);79 drizzle_result_st *result= drizzle_query(con, "insert into libdrizzle.t1 (b) values (1),(2),(3)", 0, &ret);
80 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values (1),(2),(3)");80 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values (1),(2),(3)");
81 ASSERT_TRUE(result);81 ASSERT_TRUE(result);
8282
83 ASSERT_EQ_(drizzle_result_insert_id(result), 1, "Got bad insert_id (expected 1, got %"PRIu64")", drizzle_result_insert_id(result));83 ASSERT_EQ_(drizzle_result_insert_id(result), 1, "Got bad insert_id (expected 1, got %"PRIu64")", drizzle_result_insert_id(result));
84 drizzle_result_free(result);84 drizzle_result_free(result);
8585
86 result= drizzle_query_str(con, "INSERT INTO libdrizzle.t1 (b) VALUES (4),(5),(6)", &ret);86 result= drizzle_query(con, "INSERT INTO libdrizzle.t1 (b) VALUES (4),(5),(6)", 0, &ret);
87 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "INSERT INTO libdrizzle.t1 (b) VALUES (4),(5),(6)");87 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "INSERT INTO libdrizzle.t1 (b) VALUES (4),(5),(6)");
8888
89 ASSERT_EQ_(drizzle_result_insert_id(result), 4, "Got bad insert_id (expected 4, got %"PRIu64")", drizzle_result_insert_id(result));89 ASSERT_EQ_(drizzle_result_insert_id(result), 4, "Got bad insert_id (expected 4, got %"PRIu64")", drizzle_result_insert_id(result));
90 drizzle_result_free(result);90 drizzle_result_free(result);
9191
92 drizzle_query_str(con, "DROP TABLE libdrizzle.t1", &ret);92 drizzle_query(con, "DROP TABLE libdrizzle.t1", 0, &ret);
93 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "dROP TABLE failure");93 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "dROP TABLE failure");
9494
95 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);95 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
96 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));96 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));
9797
98 ret= drizzle_quit(con);98 ret= drizzle_quit(con);
9999
=== modified file 'tests/unit/query.c'
--- tests/unit/query.c 2013-01-05 11:41:26 +0000
+++ tests/unit/query.c 2013-01-10 22:17:22 +0000
@@ -65,30 +65,30 @@
65 }65 }
66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));
6767
68 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);68 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7070
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query(con, "CREATE SCHEMA libdrizzle", 0, &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 ret= drizzle_select_db(con, "libdrizzle");74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);77 drizzle_query(con, "create table libdrizzle.t1 (a int)", 0, &ret);
78 if (ret != DRIZZLE_RETURN_OK)78 if (ret != DRIZZLE_RETURN_OK)
79 {79 {
80 printf("Create table failure\n");80 printf("Create table failure\n");
81 return EXIT_FAILURE;81 return EXIT_FAILURE;
82 }82 }
8383
84 drizzle_query_str(con, "insert into libdrizzle.t1 values (1),(2),(3)", &ret);84 drizzle_query(con, "insert into libdrizzle.t1 values (1),(2),(3)", 0, &ret);
85 if (ret != DRIZZLE_RETURN_OK)85 if (ret != DRIZZLE_RETURN_OK)
86 {86 {
87 printf("Insert failure\n");87 printf("Insert failure\n");
88 return EXIT_FAILURE;88 return EXIT_FAILURE;
89 }89 }
9090
91 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);91 drizzle_result_st *result= drizzle_query(con, "select * from libdrizzle.t1", 0, &ret);
92 if (ret != DRIZZLE_RETURN_OK)92 if (ret != DRIZZLE_RETURN_OK)
93 {93 {
94 printf("Select failure\n");94 printf("Select failure\n");
@@ -123,10 +123,10 @@
123123
124 drizzle_result_free(result);124 drizzle_result_free(result);
125125
126 drizzle_query_str(con, "DROP TABLE libdrizzle.t1", &ret);126 drizzle_query(con, "DROP TABLE libdrizzle.t1", 0, &ret);
127 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");127 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");
128128
129 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);129 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
130 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));130 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));
131131
132 ret= drizzle_quit(con);132 ret= drizzle_quit(con);
133133
=== modified file 'tests/unit/row.c'
--- tests/unit/row.c 2013-01-05 15:56:07 +0000
+++ tests/unit/row.c 2013-01-10 22:17:22 +0000
@@ -65,30 +65,30 @@
65 }65 }
66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));
6767
68 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);68 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7070
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query(con, "CREATE SCHEMA libdrizzle", 0, &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 ret= drizzle_select_db(con, "libdrizzle");74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);77 drizzle_query(con, "create table libdrizzle.t1 (a int)", 0, &ret);
78 if (ret != DRIZZLE_RETURN_OK)78 if (ret != DRIZZLE_RETURN_OK)
79 {79 {
80 printf("Create table failure\n");80 printf("Create table failure\n");
81 return EXIT_FAILURE;81 return EXIT_FAILURE;
82 }82 }
8383
84 drizzle_query_str(con, "insert into libdrizzle.t1 values (1),(2),(3)", &ret);84 drizzle_query(con, "insert into libdrizzle.t1 values (1),(2),(3)", 0, &ret);
85 if (ret != DRIZZLE_RETURN_OK)85 if (ret != DRIZZLE_RETURN_OK)
86 {86 {
87 printf("Insert failure\n");87 printf("Insert failure\n");
88 return EXIT_FAILURE;88 return EXIT_FAILURE;
89 }89 }
9090
91 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);91 drizzle_result_st *result= drizzle_query(con, "select * from libdrizzle.t1", 0, &ret);
92 if (ret != DRIZZLE_RETURN_OK)92 if (ret != DRIZZLE_RETURN_OK)
93 {93 {
94 printf("Select failure\n");94 printf("Select failure\n");
@@ -147,10 +147,10 @@
147147
148 drizzle_result_free(result);148 drizzle_result_free(result);
149149
150 drizzle_query_str(con, "DROP TABLE libdrizzle.t1", &ret);150 drizzle_query(con, "DROP TABLE libdrizzle.t1", 0, &ret);
151 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");151 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");
152152
153 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);153 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
154 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));154 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));
155155
156 ret= drizzle_quit(con);156 ret= drizzle_quit(con);
157157
=== modified file 'tests/unit/statement.c'
--- tests/unit/statement.c 2013-01-05 11:41:26 +0000
+++ tests/unit/statement.c 2013-01-10 22:17:22 +0000
@@ -67,19 +67,19 @@
67 }67 }
68 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));68 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));
6969
70 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);70 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
71 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));71 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7272
73 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);73 drizzle_query(con, "CREATE SCHEMA libdrizzle", 0, &ret);
74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7575
76 ret= drizzle_select_db(con, "libdrizzle");76 ret= drizzle_select_db(con, "libdrizzle");
77 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");77 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7878
79 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);79 drizzle_query(con, "create table libdrizzle.t1 (a int)", 0, &ret);
80 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "create table libdrizzle.t1 (a int): %s", drizzle_error(con));80 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "create table libdrizzle.t1 (a int): %s", drizzle_error(con));
8181
82 drizzle_query_str(con, "insert into libdrizzle.t1 values (1),(2),(3)", &ret);82 drizzle_query(con, "insert into libdrizzle.t1 values (1),(2),(3)", 0, &ret);
83 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s", drizzle_error(con));83 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s", drizzle_error(con));
8484
85 const char *query= "select * from libdrizzle.t1 where a > ?";85 const char *query= "select * from libdrizzle.t1 where a > ?";
@@ -159,10 +159,10 @@
159 return EXIT_FAILURE;159 return EXIT_FAILURE;
160 }160 }
161161
162 drizzle_query_str(con, "DROP TABLE libdrizzle.t1", &ret);162 drizzle_query(con, "DROP TABLE libdrizzle.t1", 0, &ret);
163 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");163 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");
164164
165 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);165 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
166 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));166 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));
167167
168 ret= drizzle_quit(con);168 ret= drizzle_quit(con);
169169
=== modified file 'tests/unit/statement_char.c'
--- tests/unit/statement_char.c 2013-01-05 11:41:26 +0000
+++ tests/unit/statement_char.c 2013-01-10 22:17:22 +0000
@@ -68,19 +68,19 @@
68 }68 }
69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));
7070
71 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);71 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);74 drizzle_query(con, "CREATE SCHEMA libdrizzle", 0, &ret);
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7676
77 ret= drizzle_select_db(con, "libdrizzle");77 ret= drizzle_select_db(con, "libdrizzle");
78 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");78 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7979
80 drizzle_query_str(con, "create table libdrizzle.t1 (a varchar(50))", &ret);80 drizzle_query(con, "create table libdrizzle.t1 (a varchar(50))", 0, &ret);
81 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "create table libdrizzle.t1 (a int): %s", drizzle_error(con));81 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "create table libdrizzle.t1 (a int): %s", drizzle_error(con));
8282
83 drizzle_query_str(con, "insert into libdrizzle.t1 values ('hello'),('drizzle'),('people')", &ret);83 drizzle_query(con, "insert into libdrizzle.t1 values ('hello'),('drizzle'),('people')", 0, &ret);
84 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s", drizzle_error(con));84 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "%s", drizzle_error(con));
8585
86 const char *query= "select * from libdrizzle.t1 where a = ?";86 const char *query= "select * from libdrizzle.t1 where a = ?";
@@ -143,10 +143,10 @@
143 return EXIT_FAILURE;143 return EXIT_FAILURE;
144 }144 }
145145
146 drizzle_query_str(con, "DROP TABLE libdrizzle.t1", &ret);146 drizzle_query(con, "DROP TABLE libdrizzle.t1", 0, &ret);
147 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");147 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");
148148
149 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);149 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
150 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));150 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));
151151
152 ret= drizzle_quit(con);152 ret= drizzle_quit(con);
153153
=== modified file 'tests/unit/unbuffered_query.c'
--- tests/unit/unbuffered_query.c 2013-01-05 11:41:26 +0000
+++ tests/unit/unbuffered_query.c 2013-01-10 22:17:22 +0000
@@ -65,30 +65,30 @@
65 }65 }
66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));66 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_connect(): %s(%s)", drizzle_error(con), drizzle_strerror(ret));
6767
68 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);68 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));69 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7070
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query(con, "CREATE SCHEMA libdrizzle", 0, &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 ret= drizzle_select_db(con, "libdrizzle");74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);77 drizzle_query(con, "create table libdrizzle.t1 (a int)", 0, &ret);
78 if (ret != DRIZZLE_RETURN_OK)78 if (ret != DRIZZLE_RETURN_OK)
79 {79 {
80 printf("Create table failure\n");80 printf("Create table failure\n");
81 return EXIT_FAILURE;81 return EXIT_FAILURE;
82 }82 }
8383
84 drizzle_query_str(con, "insert into libdrizzle.t1 values (1),(2),(3)", &ret);84 drizzle_query(con, "insert into libdrizzle.t1 values (1),(2),(3)", 0, &ret);
85 if (ret != DRIZZLE_RETURN_OK)85 if (ret != DRIZZLE_RETURN_OK)
86 {86 {
87 printf("Insert failure\n");87 printf("Insert failure\n");
88 return EXIT_FAILURE;88 return EXIT_FAILURE;
89 }89 }
9090
91 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);91 drizzle_result_st *result= drizzle_query(con, "select * from libdrizzle.t1", 0, &ret);
92 if (ret != DRIZZLE_RETURN_OK)92 if (ret != DRIZZLE_RETURN_OK)
93 {93 {
94 printf("Select failure\n");94 printf("Select failure\n");
@@ -141,10 +141,10 @@
141141
142 drizzle_result_free(result);142 drizzle_result_free(result);
143143
144 drizzle_query_str(con, "DROP TABLE libdrizzle.t1", &ret);144 drizzle_query(con, "DROP TABLE libdrizzle.t1", 0, &ret);
145 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");145 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP TABLE libdrizzle.t1");
146146
147 drizzle_query_str(con, "DROP SCHEMA IF EXISTS libdrizzle", &ret);147 drizzle_query(con, "DROP SCHEMA IF EXISTS libdrizzle", 0, &ret);
148 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));148 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "DROP SCHEMA libdrizzle (%s)", drizzle_error(con));
149149
150 ret= drizzle_quit(con);150 ret= drizzle_quit(con);

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: