Merge lp:~linuxjedi/libdrizzle/5.1-api-fixes into lp:libdrizzle

Proposed by Andrew Hutchings
Status: Merged
Approved by: Andrew Hutchings
Approved revision: 84
Merged at revision: 80
Proposed branch: lp:~linuxjedi/libdrizzle/5.1-api-fixes
Merge into: lp:libdrizzle
Diff against target: 1469 lines (+359/-161)
40 files modified
cli/drizzle_binlogs.c (+3/-3)
docs/api/binlog.rst (+2/-2)
docs/api/connection.rst (+2/-3)
docs/api/constants.rst (+47/-2)
docs/api/query.rst (+2/-2)
docs/api/statement.rst (+56/-1)
docs/api/structs.rst (+1/-35)
docs/examples/binlog.rst (+1/-1)
libdrizzle-5.1/binlog.h (+2/-2)
libdrizzle-5.1/column.h (+1/-1)
libdrizzle-5.1/conn.h (+1/-1)
libdrizzle-5.1/conn_client.h (+2/-3)
libdrizzle-5.1/query.h (+1/-1)
libdrizzle-5.1/return.h (+1/-0)
libdrizzle-5.1/statement.h (+19/-1)
libdrizzle-5.1/verbose.h (+1/-2)
libdrizzle/binlog.cc (+5/-5)
libdrizzle/column.cc (+2/-2)
libdrizzle/column.h (+1/-1)
libdrizzle/command.cc (+3/-3)
libdrizzle/conn.cc (+11/-8)
libdrizzle/drizzle.cc (+1/-2)
libdrizzle/drizzle_local.h (+4/-4)
libdrizzle/error.cc (+1/-0)
libdrizzle/handshake.cc (+7/-7)
libdrizzle/pack.cc (+13/-13)
libdrizzle/pack.h (+13/-13)
libdrizzle/query.cc (+7/-7)
libdrizzle/statement.cc (+12/-12)
libdrizzle/statement_local.h (+3/-0)
libdrizzle/statement_param.cc (+105/-0)
libdrizzle/structs.h (+9/-9)
tests/unit/column.c (+2/-2)
tests/unit/hex.c (+1/-1)
tests/unit/insert_id.c (+2/-2)
tests/unit/query.c (+2/-2)
tests/unit/row.c (+2/-2)
tests/unit/statement.c (+8/-2)
tests/unit/statement_char.c (+1/-2)
tests/unit/unbuffered_query.c (+2/-2)
To merge this branch: bzr merge lp:~linuxjedi/libdrizzle/5.1-api-fixes
Reviewer Review Type Date Requested Status
Drizzle Trunk Pending
Review via email: mp+142007@code.launchpad.net

Description of the change

Fixups in many areas of the API

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cli/drizzle_binlogs.c'
--- cli/drizzle_binlogs.c 2012-12-28 23:07:33 +0000
+++ cli/drizzle_binlogs.c 2013-01-05 11:52:22 +0000
@@ -138,7 +138,7 @@
138drizzle_st *_connect(void);138drizzle_st *_connect(void);
139FILE *create_binlog_file(char *binlog_file);139FILE *create_binlog_file(char *binlog_file);
140void get_binlogs(drizzle_st *con);140void get_binlogs(drizzle_st *con);
141void write_binlog(FILE* file, const uint8_t* data, uint32_t len);141void write_binlog(FILE* file, const unsigned char* data, uint32_t len);
142142
143bool get_system_user(char *dest, uint8_t len)143bool get_system_user(char *dest, uint8_t len)
144{144{
@@ -236,7 +236,7 @@
236236
237 while(1)237 while(1)
238 {238 {
239 write_binlog(outfile, (uint8_t *)DRIZZLE_BINLOG_MAGIC, 4);239 write_binlog(outfile, (unsigned char *)DRIZZLE_BINLOG_MAGIC, 4);
240 while(1)240 while(1)
241 {241 {
242 ret= drizzle_binlog_get_next_event(result);242 ret= drizzle_binlog_get_next_event(result);
@@ -274,7 +274,7 @@
274 drizzle_result_free(result);274 drizzle_result_free(result);
275}275}
276276
277void write_binlog(FILE* file, const uint8_t* data, uint32_t len)277void write_binlog(FILE* file, const unsigned char* data, uint32_t len)
278{278{
279 if (len)279 if (len)
280 {280 {
281281
=== modified file 'docs/api/binlog.rst'
--- docs/api/binlog.rst 2012-12-22 08:54:15 +0000
+++ docs/api/binlog.rst 2013-01-05 11:52:22 +0000
@@ -83,14 +83,14 @@
83 :param result: The result set for the binlog stream83 :param result: The result set for the binlog stream
84 :returns: The extra event flags84 :returns: The extra event flags
8585
86.. c:function:: const uint8_t* drizzle_binlog_event_data(drizzle_result_st *result)86.. c:function:: const unsigned char* drizzle_binlog_event_data(drizzle_result_st *result)
8787
88 Get the event data for the event received using :c:func:`drizzle_binlog_get_next_event`88 Get the event data for the event received using :c:func:`drizzle_binlog_get_next_event`
8989
90 :param result: The result set for the binlog stream90 :param result: The result set for the binlog stream
91 :returns: A pointer to the event data91 :returns: A pointer to the event data
9292
93.. c:function:: const uint8_t *drizzle_binlog_event_raw_data(drizzle_result_st *result)93.. c:function:: const unsigned char* drizzle_binlog_event_raw_data(drizzle_result_st *result)
9494
95 Get the raw event data (including header) for the event received using :c:func:`drizzle_binlog_get_next_event`95 Get the raw event data (including header) for the event received using :c:func:`drizzle_binlog_get_next_event`
9696
9797
=== modified file 'docs/api/connection.rst'
--- docs/api/connection.rst 2013-01-04 20:47:22 +0000
+++ docs/api/connection.rst 2013-01-05 11:52:22 +0000
@@ -229,14 +229,13 @@
229 :param con: A connection object229 :param con: A connection object
230 :returns: A :c:type:`drizzle_return_t` response for the quit command sent to the server230 :returns: A :c:type:`drizzle_return_t` response for the quit command sent to the server
231231
232.. c:function:: drizzle_result_st* drizzle_select_db(drizzle_st *con, const char *db, drizzle_return_t *ret_ptr)232.. c:function:: drizzle_return_t drizzle_select_db(drizzle_st *con, const char *db)
233233
234 Change the current default database234 Change the current default database
235235
236 :param con: A connection object236 :param con: A connection object
237 :param db: The new default database237 :param db: The new default database
238 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into238 :returns: A :c:type:`drizzle_return_t` response
239 :returns: A newly allocated result object
240239
241.. c:function:: drizzle_result_st* drizzle_shutdown(drizzle_st *con, drizzle_return_t *ret_ptr)240.. c:function:: drizzle_result_st* drizzle_shutdown(drizzle_st *con, drizzle_return_t *ret_ptr)
242241
243242
=== modified file 'docs/api/constants.rst'
--- docs/api/constants.rst 2012-12-23 14:57:06 +0000
+++ docs/api/constants.rst 2013-01-05 11:52:22 +0000
@@ -156,6 +156,26 @@
156156
157 No more data to retrieve157 No more data to retrieve
158158
159 .. py:data:: DRIZZLE_RETURN_STMT_ERROR
160
161 A prepared statment error has occurred
162
163 .. py:data:: DRIZZLE_RETURN_BINLOG_CRC
164
165 A checksum error has occurred in a MySQL 5.6 binlog
166
167 .. py:data:: DRIZZLE_RETURN_TRUNCATED
168
169 The result has been truncated
170
171 .. py:data:: DRIZZLE_RETURN_INVALID_CONVERSION
172
173 The data type cannot be converted into the requested type
174
175 .. py:data:: DRIZZLE_RETURN_NOT_FOUND
176
177 The requested column was not found
178
159Connection179Connection
160----------180----------
161181
@@ -1050,14 +1070,18 @@
10501070
1051 RBR Delete rows event for MySQL 5.1 pre-release1071 RBR Delete rows event for MySQL 5.1 pre-release
10521072
1053 .. py:data:: DRIZZLE_EVENT_TYPE_WRITE_ROWS1073 .. py:data:: DRIZZLE_EVENT_TYPE_V1_WRITE_ROWS
10541074
1055 RBR Write rows event1075 RBR Write rows event
10561076
1057 .. py:data:: DRIZZLE_EVENT_TYPE_UPDATE_ROWS1077 .. py:data:: DRIZZLE_EVENT_TYPE_V1_UPDATE_ROWS
10581078
1059 RBR Update rows event1079 RBR Update rows event
10601080
1081 .. py:data:: DRIZZLE_EVENT_TYPE_V1_DELETE_ROWS
1082
1083 RBR Delete rows event
1084
1061 .. py:data:: DRIZZLE_EVENT_TYPE_INCIDENT1085 .. py:data:: DRIZZLE_EVENT_TYPE_INCIDENT
10621086
1063 Replication incident message1087 Replication incident message
@@ -1066,4 +1090,25 @@
10661090
1067 Repliaction heartbeat event1091 Repliaction heartbeat event
10681092
1093 .. py:data:: DRIZZLE_EVENT_TYPE_IGNORABLE
1094
1095 .. py:data:: DRIZZLE_EVENT_TYPE_ROWS_QUERY
1096
1097 .. py:data:: DRIZZLE_EVENT_TYPE_V2_WRITE_ROWS
1098
1099 A MySQL 5.6 RBR Write rows event
1100
1101 .. py:data:: DRIZZLE_EVENT_TYPE_V2_UPDATE_ROWS
1102
1103 A MySQL 5.6 RBR Update rows event
1104
1105 .. py:data:: DRIZZLE_EVENT_TYPE_V2_DELETE_ROWS
1106
1107 A MySQL 5.6 RBR Delete rows event
1108
1109 .. py:data:: DRIZZLE_EVENT_TYPE_GTID
1110
1111 .. py:data:: DRIZZLE_EVENT_TYPE_ANONYMOUS_GTID
1112
1113 .. py:data:: DRIZZLE_EVENT_TYPE_PREVIOUS_GTIDS
10691114
10701115
=== modified file 'docs/api/query.rst'
--- docs/api/query.rst 2012-12-22 08:54:15 +0000
+++ docs/api/query.rst 2013-01-05 11:52:22 +0000
@@ -51,7 +51,7 @@
51 :param from_size: the length of the source string51 :param from_size: the length of the source string
52 :returns: the length of the 'to' string or -1 upon error due to empty parameters or overflow52 :returns: the length of the 'to' string or -1 upon error due to empty parameters or overflow
5353
54.. c:function:: bool drizzle_hex_string(char *to, const uint8_t *from, const size_t from_size)54.. c:function:: bool drizzle_hex_string(char *to, const unsigned char *from, const size_t from_size)
5555
56 Convert data into a hexadecimal string of the data.56 Convert data into a hexadecimal string of the data.
5757
@@ -269,7 +269,7 @@
269 :param column: A column object269 :param column: A column object
270 :returns: The number of decimal places270 :returns: The number of decimal places
271271
272.. c:function:: const uint8_t* drizzle_column_default_value(drizzle_column_st *column, size_t *size)272.. c:function:: const unsigned char* drizzle_column_default_value(drizzle_column_st *column, size_t *size)
273273
274 Gets the default value for a given column274 Gets the default value for a given column
275275
276276
=== modified file 'docs/api/statement.rst'
--- docs/api/statement.rst 2013-01-04 20:47:22 +0000
+++ docs/api/statement.rst 2013-01-05 11:52:22 +0000
@@ -130,7 +130,7 @@
130 :param stmt: The prepared statement object130 :param stmt: The prepared statement object
131 :returns: A return status code, :py:const:`DRIZZLE_RETURN_OK` upon success131 :returns: A return status code, :py:const:`DRIZZLE_RETURN_OK` upon success
132132
133.. c:function:: drizzle_return_t drizzle_stmt_send_long_data(drizzle_stmt_st *stmt, uint16_t param_num, uint8_t *data, size_t len)133.. c:function:: drizzle_return_t drizzle_stmt_send_long_data(drizzle_stmt_st *stmt, uint16_t param_num, unsigned char *data, size_t len)
134134
135 Send long binary data packet135 Send long binary data packet
136136
@@ -171,6 +171,15 @@
171 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into171 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into
172 :returns: True if NULL172 :returns: True if NULL
173173
174.. c:function:: bool drizzle_stmt_get_is_null_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
175
176 Check if a column for a fetched row is set to NULL using a column name
177
178 :param stmt: The prepared statement object
179 :param column_name: The column name to get
180 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into, :py:const:`DRIZZLE_RETURN_NOT_FOUND` if the column name cannot be found
181 :returns: True if NULL
182
174.. c:function:: bool drizzle_stmt_get_is_unsigned(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)183.. c:function:: bool drizzle_stmt_get_is_unsigned(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
175184
176 Check if a column for a fetched row is unsigned185 Check if a column for a fetched row is unsigned
@@ -180,6 +189,15 @@
180 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into189 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into
181 :returns: True if unsigned190 :returns: True if unsigned
182191
192.. c:function:: bool drizzle_stmt_get_is_unsigned_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
193
194 Check if a column for a fetched row is unsigned using a column name
195
196 :param stmt: The prepared statement object
197 :param column_name: The column name to get
198 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into, :py:const:`DRIZZLE_RETURN_NOT_FOUND` if the column name cannot be found
199 :returns: True if unsigned
200
183.. c:function:: const char *drizzle_stmt_get_string(drizzle_stmt_st *stmt, uint16_t column_number, size_t *len, drizzle_return_t *ret_ptr)201.. c:function:: const char *drizzle_stmt_get_string(drizzle_stmt_st *stmt, uint16_t column_number, size_t *len, drizzle_return_t *ret_ptr)
184202
185 Get the string value for a column of a fetched row (int types are automatically converted)203 Get the string value for a column of a fetched row (int types are automatically converted)
@@ -190,6 +208,16 @@
190 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into208 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into
191 :returns: A pointer to the string value209 :returns: A pointer to the string value
192210
211.. c:function:: const char *drizzle_stmt_get_string_from_name(drizzle_stmt_st *stmt, const char *column_name, size_t *len, drizzle_return_t *ret_ptr)
212
213 Get the string value for a column of a fetched row (int types are automatically converted) using a column name
214
215 :param stmt: The prepared statement object
216 :param column_name: The column name to get
217 :param len: A pointer to a :c:type:`size_t` to store the result length into
218 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into, :py:const:`DRIZZLE_RETURN_NOT_FOUND` if the column name cannot be found
219 :returns: A pointer to the string value
220
193.. c:function:: uint32_t drizzle_stmt_get_int(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)221.. c:function:: uint32_t drizzle_stmt_get_int(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
194222
195 Get the int value for a column of a fetched row223 Get the int value for a column of a fetched row
@@ -199,6 +227,15 @@
199 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred227 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred
200 :returns: The int value228 :returns: The int value
201229
230.. c:function:: uint32_t drizzle_stmt_get_int_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
231
232 Get the int value for a column of a fetched row using a column name
233
234 :param stmt: The prepared statement object
235 :param column_name: The column name to get
236 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred, :py:const:`DRIZZLE_RETURN_NOT_FOUND` if the column name cannot be found
237 :returns: The int value
238
202.. c:function:: uint64_t drizzle_stmt_get_bigint(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)239.. c:function:: uint64_t drizzle_stmt_get_bigint(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
203240
204 Get the bigint value for a column of a fetched row241 Get the bigint value for a column of a fetched row
@@ -208,6 +245,15 @@
208 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred245 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred
209 :returns: The bigint value246 :returns: The bigint value
210247
248.. c:function:: uint64_t drizzle_stmt_get_bigint_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
249
250 Get the bigint value for a column of a fetched row using a column name
251
252 :param stmt: The prepared statement object
253 :param column_name: The column name to get
254 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred, :py:const:`DRIZZLE_RETURN_NOT_FOUND` if the column name cannot be found
255 :returns: The bigint value
256
211.. c:function:: double drizzle_stmt_get_double(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)257.. c:function:: double drizzle_stmt_get_double(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
212258
213 Get the double value for a column of a fetched row259 Get the double value for a column of a fetched row
@@ -217,6 +263,15 @@
217 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred263 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred
218 :returns: The double value264 :returns: The double value
219265
266.. c:function:: double drizzle_stmt_get_double_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
267
268 Get the double value for a column of a fetched row from a column name
269
270 :param stmt: The prepared statement object
271 :param column_name: The column name to get
272 :param ret_ptr: A pointer to a :c:type:`drizzle_return_t` to store the return status into :py:const:`DRIZZLE_RETURN_TRUNCATED` if a truncation has occurred, :py:const:`DRIZZLE_RETURN_NOT_FOUND` if the column name cannot be found
273 :returns: The double value
274
220.. c:function:: drizzle_return_t drizzle_stmt_close(drizzle_stmt_st *stmt)275.. c:function:: drizzle_return_t drizzle_stmt_close(drizzle_stmt_st *stmt)
221276
222 Close and free a prepared statement277 Close and free a prepared statement
223278
=== modified file 'docs/api/structs.rst'
--- docs/api/structs.rst 2012-12-23 14:44:44 +0000
+++ docs/api/structs.rst 2013-01-05 11:52:22 +0000
@@ -19,41 +19,7 @@
1919
20.. c:type:: drizzle_datetime_st20.. c:type:: drizzle_datetime_st
2121
22 The struct for passing a date/time to/from the prepared statement API22 The internal struct for passing a date/time to/from the prepared statement API
23
24 .. c:member:: uint16_t year
25
26 The year part of the date
27
28 .. c:member:: uint8_t month
29
30 The month part of the date
31
32 .. c:member:: uint32_t day
33
34 The day part of the date
35
36 .. c:member:: uint16_t hour
37
38 The hour part of the time
39
40 .. c:member:: uint8_t minute
41
42 The minute part of the time
43
44 .. c:member:: uint8_t second
45
46 The second part of the time
47
48 .. c:member:: uint32_t microsecond
49
50 The microsecond part of the time
51
52 .. c:member:: bool negative
53
54 Is the time negative
55
56
57Binlog23Binlog
58------24------
5925
6026
=== modified file 'docs/examples/binlog.rst'
--- docs/examples/binlog.rst 2012-12-24 10:20:04 +0000
+++ docs/examples/binlog.rst 2013-01-05 11:52:22 +0000
@@ -38,7 +38,7 @@
38 while (ret == DRIZZLE_RETURN_OK)38 while (ret == DRIZZLE_RETURN_OK)
39 {39 {
40 uint32_t i, length;40 uint32_t i, length;
41 const uint8_t *data;41 const unsigned char *data;
42 ret= drizzle_binlog_get_event(result);42 ret= drizzle_binlog_get_event(result);
43 if (ret != DRIZZLE_RETURN_OK)43 if (ret != DRIZZLE_RETURN_OK)
44 break;44 break;
4545
=== modified file 'libdrizzle-5.1/binlog.h'
--- libdrizzle-5.1/binlog.h 2012-12-31 00:19:49 +0000
+++ libdrizzle-5.1/binlog.h 2013-01-05 11:52:22 +0000
@@ -73,10 +73,10 @@
73uint16_t drizzle_binlog_event_extra_flags(drizzle_result_st *result);73uint16_t drizzle_binlog_event_extra_flags(drizzle_result_st *result);
7474
75DRIZZLE_API75DRIZZLE_API
76const uint8_t *drizzle_binlog_event_data(drizzle_result_st *result);76const unsigned char *drizzle_binlog_event_data(drizzle_result_st *result);
7777
78DRIZZLE_API78DRIZZLE_API
79const uint8_t *drizzle_binlog_event_raw_data(drizzle_result_st *result);79const unsigned char *drizzle_binlog_event_raw_data(drizzle_result_st *result);
8080
81DRIZZLE_API81DRIZZLE_API
82uint32_t drizzle_binlog_event_raw_length(drizzle_result_st *result);82uint32_t drizzle_binlog_event_raw_length(drizzle_result_st *result);
8383
=== modified file 'libdrizzle-5.1/column.h'
--- libdrizzle-5.1/column.h 2012-12-30 11:18:18 +0000
+++ libdrizzle-5.1/column.h 2013-01-05 11:52:22 +0000
@@ -145,7 +145,7 @@
145 * Get default value for a column.145 * Get default value for a column.
146 */146 */
147DRIZZLE_API147DRIZZLE_API
148const uint8_t *drizzle_column_default_value(drizzle_column_st *column,148const unsigned char *drizzle_column_default_value(drizzle_column_st *column,
149 size_t *size);149 size_t *size);
150150
151/** @} */151/** @} */
152152
=== modified file 'libdrizzle-5.1/conn.h'
--- libdrizzle-5.1/conn.h 2012-12-30 11:18:18 +0000
+++ libdrizzle-5.1/conn.h 2013-01-05 11:52:22 +0000
@@ -307,7 +307,7 @@
307 * @return Scramble buffer for connection.307 * @return Scramble buffer for connection.
308 */308 */
309DRIZZLE_API309DRIZZLE_API
310const uint8_t *drizzle_scramble(const drizzle_st *con);310const unsigned char *drizzle_scramble(const drizzle_st *con);
311311
312/**312/**
313 * Get capabilities for a connection.313 * Get capabilities for a connection.
314314
=== modified file 'libdrizzle-5.1/conn_client.h'
--- libdrizzle-5.1/conn_client.h 2012-12-29 21:44:53 +0000
+++ libdrizzle-5.1/conn_client.h 2013-01-05 11:52:22 +0000
@@ -83,9 +83,8 @@
83 * failure this will be NULL.83 * failure this will be NULL.
84 */84 */
85DRIZZLE_API85DRIZZLE_API
86drizzle_result_st *drizzle_select_db(drizzle_st *con,86drizzle_return_t drizzle_select_db(drizzle_st *con,
87 const char *db,87 const char *db);
88 drizzle_return_t *ret_ptr);
8988
90/**89/**
91 * Send a shutdown message to the server.90 * Send a shutdown message to the server.
9291
=== modified file 'libdrizzle-5.1/query.h'
--- libdrizzle-5.1/query.h 2012-12-22 08:54:15 +0000
+++ libdrizzle-5.1/query.h 2013-01-05 11:52:22 +0000
@@ -90,7 +90,7 @@
90ssize_t drizzle_escape_string(char *to, const size_t max_to_size, const char *from, const size_t from_size);90ssize_t drizzle_escape_string(char *to, const size_t max_to_size, const char *from, const size_t from_size);
9191
92DRIZZLE_API92DRIZZLE_API
93bool drizzle_hex_string(char *to, const uint8_t *from, const size_t from_size);93bool drizzle_hex_string(char *to, const unsigned char *from, const size_t from_size);
9494
95DRIZZLE_API95DRIZZLE_API
96bool drizzle_mysql_password_hash(char *to, const char *from, const size_t from_size);96bool drizzle_mysql_password_hash(char *to, const char *from, const size_t from_size);
9797
=== modified file 'libdrizzle-5.1/return.h'
--- libdrizzle-5.1/return.h 2012-12-30 20:08:04 +0000
+++ libdrizzle-5.1/return.h 2013-01-05 11:52:22 +0000
@@ -73,6 +73,7 @@
73 DRIZZLE_RETURN_BINLOG_CRC,73 DRIZZLE_RETURN_BINLOG_CRC,
74 DRIZZLE_RETURN_TRUNCATED,74 DRIZZLE_RETURN_TRUNCATED,
75 DRIZZLE_RETURN_INVALID_CONVERSION,75 DRIZZLE_RETURN_INVALID_CONVERSION,
76 DRIZZLE_RETURN_NOT_FOUND,
76 DRIZZLE_RETURN_MAX /* Always add new codes to the end before this one. */77 DRIZZLE_RETURN_MAX /* Always add new codes to the end before this one. */
77};78};
7879
7980
=== modified file 'libdrizzle-5.1/statement.h'
--- libdrizzle-5.1/statement.h 2012-12-31 09:54:55 +0000
+++ libdrizzle-5.1/statement.h 2013-01-05 11:52:22 +0000
@@ -48,7 +48,7 @@
48drizzle_return_t drizzle_stmt_execute(drizzle_stmt_st *stmt);48drizzle_return_t drizzle_stmt_execute(drizzle_stmt_st *stmt);
4949
50DRIZZLE_API50DRIZZLE_API
51drizzle_return_t drizzle_stmt_send_long_data(drizzle_stmt_st *stmt, uint16_t param_num, uint8_t *data, size_t len);51drizzle_return_t drizzle_stmt_send_long_data(drizzle_stmt_st *stmt, uint16_t param_num, unsigned char *data, size_t len);
5252
53DRIZZLE_API53DRIZZLE_API
54drizzle_return_t drizzle_stmt_reset(drizzle_stmt_st *stmt);54drizzle_return_t drizzle_stmt_reset(drizzle_stmt_st *stmt);
@@ -108,23 +108,41 @@
108drizzle_return_t drizzle_stmt_set_timestamp(drizzle_stmt_st *stmt, uint16_t param_num, uint16_t year, uint8_t month, uint8_t day, uint8_t hours, uint8_t minutes, uint8_t seconds, uint32_t microseconds);108drizzle_return_t drizzle_stmt_set_timestamp(drizzle_stmt_st *stmt, uint16_t param_num, uint16_t year, uint8_t month, uint8_t day, uint8_t hours, uint8_t minutes, uint8_t seconds, uint32_t microseconds);
109109
110DRIZZLE_API110DRIZZLE_API
111bool drizzle_stmt_get_is_null_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr);
112
113DRIZZLE_API
111bool drizzle_stmt_get_is_null(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);114bool drizzle_stmt_get_is_null(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);
112115
113DRIZZLE_API116DRIZZLE_API
117bool drizzle_stmt_get_is_unsigned_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr);
118
119DRIZZLE_API
114bool drizzle_stmt_get_is_unsigned(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);120bool drizzle_stmt_get_is_unsigned(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);
115121
116DRIZZLE_API122DRIZZLE_API
123const char *drizzle_stmt_get_string_from_name(drizzle_stmt_st *stmt, const char *column_name, size_t *len, drizzle_return_t *ret_ptr);
124
125DRIZZLE_API
117const char *drizzle_stmt_get_string(drizzle_stmt_st *stmt, uint16_t column_number, size_t *len, drizzle_return_t *ret_ptr);126const char *drizzle_stmt_get_string(drizzle_stmt_st *stmt, uint16_t column_number, size_t *len, drizzle_return_t *ret_ptr);
118127
119DRIZZLE_API128DRIZZLE_API
120uint32_t drizzle_stmt_get_int(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);129uint32_t drizzle_stmt_get_int(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);
121130
122DRIZZLE_API131DRIZZLE_API
132uint32_t drizzle_stmt_get_int_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr);
133
134DRIZZLE_API
135uint64_t drizzle_stmt_get_bigint_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr);
136
137DRIZZLE_API
123uint64_t drizzle_stmt_get_bigint(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);138uint64_t drizzle_stmt_get_bigint(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);
124139
125DRIZZLE_API140DRIZZLE_API
126double drizzle_stmt_get_double(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);141double drizzle_stmt_get_double(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr);
127142
143DRIZZLE_API
144double drizzle_stmt_get_double_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr);
145
128#ifdef __cplusplus146#ifdef __cplusplus
129}147}
130#endif148#endif
131149
=== modified file 'libdrizzle-5.1/verbose.h'
--- libdrizzle-5.1/verbose.h 2012-12-18 11:36:28 +0000
+++ libdrizzle-5.1/verbose.h 2013-01-05 11:52:22 +0000
@@ -42,11 +42,10 @@
42enum drizzle_verbose_t42enum drizzle_verbose_t
43{43{
44 DRIZZLE_VERBOSE_NEVER,44 DRIZZLE_VERBOSE_NEVER,
45 DRIZZLE_VERBOSE_FATAL,45 DRIZZLE_VERBOSE_CRITICAL,
46 DRIZZLE_VERBOSE_ERROR,46 DRIZZLE_VERBOSE_ERROR,
47 DRIZZLE_VERBOSE_INFO,47 DRIZZLE_VERBOSE_INFO,
48 DRIZZLE_VERBOSE_DEBUG,48 DRIZZLE_VERBOSE_DEBUG,
49 DRIZZLE_VERBOSE_CRAZY,
50 DRIZZLE_VERBOSE_MAX49 DRIZZLE_VERBOSE_MAX
51};50};
5251
5352
=== modified file 'libdrizzle/binlog.cc'
--- libdrizzle/binlog.cc 2012-12-29 17:31:57 +0000
+++ libdrizzle/binlog.cc 2013-01-05 11:52:22 +0000
@@ -45,8 +45,8 @@
45 uint32_t start_position,45 uint32_t start_position,
46 drizzle_return_t *ret_ptr)46 drizzle_return_t *ret_ptr)
47{ 47{
48 uint8_t data[128];48 unsigned char data[128];
49 uint8_t *ptr;49 unsigned char *ptr;
50 uint8_t len= 0, fn_len= 0;50 uint8_t len= 0, fn_len= 0;
51 drizzle_result_st *result;51 drizzle_result_st *result;
5252
@@ -179,7 +179,7 @@
179 return result->binlog_event->extra_flags;179 return result->binlog_event->extra_flags;
180}180}
181181
182const uint8_t *drizzle_binlog_event_data(drizzle_result_st *result)182const unsigned char *drizzle_binlog_event_data(drizzle_result_st *result)
183{183{
184 if ((result == NULL) || (result->binlog_event == NULL))184 if ((result == NULL) || (result->binlog_event == NULL))
185 {185 {
@@ -189,7 +189,7 @@
189 return result->binlog_event->data;189 return result->binlog_event->data;
190}190}
191191
192const uint8_t *drizzle_binlog_event_raw_data(drizzle_result_st *result)192const unsigned char *drizzle_binlog_event_raw_data(drizzle_result_st *result)
193{193{
194 if ((result == NULL) || (result->binlog_event == NULL))194 if ((result == NULL) || (result->binlog_event == NULL))
195 {195 {
@@ -306,7 +306,7 @@
306 con->buffer_ptr+= 27;306 con->buffer_ptr+= 27;
307 con->buffer_size-= 27;307 con->buffer_size-= 27;
308 con->packet_size-= 27;308 con->packet_size-= 27;
309 binlog_event->data= (uint8_t*)realloc(binlog_event->data, binlog_event->length);309 binlog_event->data= (unsigned char*)realloc(binlog_event->data, binlog_event->length);
310 /* 5.6.1 or higher is automatic checksums on */310 /* 5.6.1 or higher is automatic checksums on */
311 if (binlog_event->type == DRIZZLE_EVENT_TYPE_FORMAT_DESCRIPTION)311 if (binlog_event->type == DRIZZLE_EVENT_TYPE_FORMAT_DESCRIPTION)
312 {312 {
313313
=== modified file 'libdrizzle/column.cc'
--- libdrizzle/column.cc 2012-12-26 10:02:04 +0000
+++ libdrizzle/column.cc 2013-01-05 11:52:22 +0000
@@ -242,7 +242,7 @@
242 return column->decimals;242 return column->decimals;
243}243}
244244
245const uint8_t *drizzle_column_default_value(drizzle_column_st *column,245const unsigned char *drizzle_column_default_value(drizzle_column_st *column,
246 size_t *size)246 size_t *size)
247{247{
248 if (column == NULL)248 if (column == NULL)
@@ -442,7 +442,7 @@
442 */442 */
443443
444void drizzle_column_set_default_value(drizzle_column_st *column,444void drizzle_column_set_default_value(drizzle_column_st *column,
445 const uint8_t *default_value,445 const unsigned char *default_value,
446 size_t size)446 size_t size)
447{447{
448 if (column == NULL)448 if (column == NULL)
449449
=== modified file 'libdrizzle/column.h'
--- libdrizzle/column.h 2012-12-30 11:18:18 +0000
+++ libdrizzle/column.h 2013-01-05 11:52:22 +0000
@@ -43,7 +43,7 @@
43drizzle_column_st *drizzle_column_create(drizzle_result_st *result);43drizzle_column_st *drizzle_column_create(drizzle_result_st *result);
4444
45void drizzle_column_set_default_value(drizzle_column_st *column,45void drizzle_column_set_default_value(drizzle_column_st *column,
46 const uint8_t *default_value,46 const unsigned char *default_value,
47 size_t size);47 size_t size);
4848
4949
5050
=== modified file 'libdrizzle/command.cc'
--- libdrizzle/command.cc 2012-12-22 08:54:15 +0000
+++ libdrizzle/command.cc 2013-01-05 11:52:22 +0000
@@ -50,8 +50,8 @@
5050
51drizzle_return_t drizzle_state_command_write(drizzle_st *con)51drizzle_return_t drizzle_state_command_write(drizzle_st *con)
52{52{
53 uint8_t *start;53 unsigned char *start;
54 uint8_t *ptr;54 unsigned char *ptr;
55 drizzle_return_t ret;55 drizzle_return_t ret;
5656
57 if (con == NULL)57 if (con == NULL)
@@ -102,7 +102,7 @@
102 con->packet_number= 1;102 con->packet_number= 1;
103 ptr= start;103 ptr= start;
104 ptr[3]= 0;104 ptr[3]= 0;
105 ptr[4]= (uint8_t)(con->command);105 ptr[4]= (unsigned char)(con->command);
106 ptr+= 5;106 ptr+= 5;
107107
108 if (con->command == DRIZZLE_COMMAND_CHANGE_USER)108 if (con->command == DRIZZLE_COMMAND_CHANGE_USER)
109109
=== modified file 'libdrizzle/conn.cc'
--- libdrizzle/conn.cc 2013-01-04 10:21:06 +0000
+++ libdrizzle/conn.cc 2013-01-05 11:52:22 +0000
@@ -567,7 +567,7 @@
567 return con->thread_id;567 return con->thread_id;
568}568}
569569
570const uint8_t *drizzle_scramble(const drizzle_st *con)570const unsigned char *drizzle_scramble(const drizzle_st *con)
571{571{
572 if (con == NULL)572 if (con == NULL)
573 {573 {
@@ -671,13 +671,16 @@
671 return DRIZZLE_RETURN_INVALID_ARGUMENT;671 return DRIZZLE_RETURN_INVALID_ARGUMENT;
672}672}
673673
674drizzle_result_st *drizzle_select_db(drizzle_st *con,674drizzle_return_t drizzle_select_db(drizzle_st *con,
675 const char *db,675 const char *db)
676 drizzle_return_t *ret_ptr)
677{676{
677 drizzle_result_st *result;
678 drizzle_return_t ret;
678 drizzle_set_db(con, db);679 drizzle_set_db(con, db);
679 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_INIT_DB,680 result= drizzle_command_write(con, NULL, DRIZZLE_COMMAND_INIT_DB,
680 db, strlen(db), strlen(db), ret_ptr);681 db, strlen(db), strlen(db), &ret);
682 drizzle_result_free(result);
683 return ret;
681}684}
682685
683drizzle_result_st *drizzle_shutdown(drizzle_st *con,686drizzle_result_st *drizzle_shutdown(drizzle_st *con,
@@ -780,7 +783,7 @@
780 }783 }
781784
782 con->command= command;785 con->command= command;
783 con->command_data= (uint8_t *)data;786 con->command_data= (unsigned char *)data;
784 con->command_size= size;787 con->command_size= size;
785 con->command_offset= 0;788 con->command_offset= 0;
786 con->command_total= total;789 con->command_total= total;
@@ -789,7 +792,7 @@
789 }792 }
790 else if (con->command_data == NULL)793 else if (con->command_data == NULL)
791 {794 {
792 con->command_data= (uint8_t *)data;795 con->command_data= (unsigned char *)data;
793 con->command_size= size;796 con->command_size= size;
794 }797 }
795798
796799
=== modified file 'libdrizzle/drizzle.cc'
--- libdrizzle/drizzle.cc 2012-12-30 02:23:50 +0000
+++ libdrizzle/drizzle.cc 2013-01-05 11:52:22 +0000
@@ -55,11 +55,10 @@
55static const char *_verbose_name[DRIZZLE_VERBOSE_MAX]=55static const char *_verbose_name[DRIZZLE_VERBOSE_MAX]=
56{56{
57 "NEVER",57 "NEVER",
58 "FATAL",58 "CRITICAL",
59 "ERROR",59 "ERROR",
60 "INFO",60 "INFO",
61 "DEBUG",61 "DEBUG",
62 "CRAZY"
63};62};
6463
65/** @} */64/** @} */
6665
=== modified file 'libdrizzle/drizzle_local.h'
--- libdrizzle/drizzle_local.h 2012-12-30 11:18:18 +0000
+++ libdrizzle/drizzle_local.h 2013-01-05 11:52:22 +0000
@@ -106,10 +106,10 @@
106{106{
107 va_list args;107 va_list args;
108108
109 if (con->verbose >= DRIZZLE_VERBOSE_FATAL)109 if (con->verbose >= DRIZZLE_VERBOSE_CRITICAL)
110 {110 {
111 va_start(args, format);111 va_start(args, format);
112 drizzle_log(con, DRIZZLE_VERBOSE_FATAL, format, args);112 drizzle_log(con, DRIZZLE_VERBOSE_CRITICAL, format, args);
113 va_end(args);113 va_end(args);
114 }114 }
115}115}
@@ -170,10 +170,10 @@
170{170{
171 va_list args;171 va_list args;
172172
173 if (con->verbose >= DRIZZLE_VERBOSE_CRAZY)173 if (con->verbose >= DRIZZLE_VERBOSE_DEBUG)
174 {174 {
175 va_start(args, format);175 va_start(args, format);
176 drizzle_log(con, DRIZZLE_VERBOSE_CRAZY, format, args);176 drizzle_log(con, DRIZZLE_VERBOSE_DEBUG, format, args);
177 va_end(args);177 va_end(args);
178 }178 }
179}179}
180180
=== modified file 'libdrizzle/error.cc'
--- libdrizzle/error.cc 2012-12-30 20:08:04 +0000
+++ libdrizzle/error.cc 2013-01-05 11:52:22 +0000
@@ -72,6 +72,7 @@
72 case DRIZZLE_RETURN_BINLOG_CRC: return "DRIZZLE_RETURN_BINLOG_CRC";72 case DRIZZLE_RETURN_BINLOG_CRC: return "DRIZZLE_RETURN_BINLOG_CRC";
73 case DRIZZLE_RETURN_TRUNCATED: return "DRIZZLE_RETURN_TRUNCATED";73 case DRIZZLE_RETURN_TRUNCATED: return "DRIZZLE_RETURN_TRUNCATED";
74 case DRIZZLE_RETURN_INVALID_CONVERSION: return "DRIZZLE_RETURN_INVALID_CONVERSION";74 case DRIZZLE_RETURN_INVALID_CONVERSION: return "DRIZZLE_RETURN_INVALID_CONVERSION";
75 case DRIZZLE_RETURN_NOT_FOUND: return "DRIZZLE_RETURN_NOT_FOUND";
75 case DRIZZLE_RETURN_MAX: return "DRIZZLE_RETURN_MAX";76 case DRIZZLE_RETURN_MAX: return "DRIZZLE_RETURN_MAX";
76 }77 }
7778
7879
=== modified file 'libdrizzle/handshake.cc'
--- libdrizzle/handshake.cc 2012-12-22 13:07:06 +0000
+++ libdrizzle/handshake.cc 2013-01-05 11:52:22 +0000
@@ -81,7 +81,7 @@
8181
82drizzle_return_t drizzle_state_handshake_server_read(drizzle_st *con)82drizzle_return_t drizzle_state_handshake_server_read(drizzle_st *con)
83{83{
84 uint8_t *ptr;84 unsigned char *ptr;
85 int extra_length;85 int extra_length;
86 unsigned char* packet_end;86 unsigned char* packet_end;
8787
@@ -128,7 +128,7 @@
128 }128 }
129129
130 /* Look for null-terminated server version string. */130 /* Look for null-terminated server version string. */
131 ptr= (uint8_t*)memchr(con->buffer_ptr, 0, con->buffer_size - 1);131 ptr= (unsigned char*)memchr(con->buffer_ptr, 0, con->buffer_size - 1);
132 if (ptr == NULL)132 if (ptr == NULL)
133 {133 {
134 drizzle_set_error(con, "drizzle_state_handshake_server_read",134 drizzle_set_error(con, "drizzle_state_handshake_server_read",
@@ -218,7 +218,7 @@
218218
219drizzle_return_t drizzle_state_handshake_server_write(drizzle_st *con)219drizzle_return_t drizzle_state_handshake_server_write(drizzle_st *con)
220{220{
221 uint8_t *ptr;221 unsigned char *ptr;
222222
223 if (con == NULL)223 if (con == NULL)
224 {224 {
@@ -371,7 +371,7 @@
371 con->buffer_ptr+= 23;371 con->buffer_ptr+= 23;
372372
373 /* Look for null-terminated user string. */373 /* Look for null-terminated user string. */
374 uint8_t *ptr= (uint8_t*)memchr(con->buffer_ptr, 0, con->buffer_size - 32);374 unsigned char *ptr= (unsigned char*)memchr(con->buffer_ptr, 0, con->buffer_size - 32);
375 if (ptr == NULL)375 if (ptr == NULL)
376 {376 {
377 drizzle_set_error(con, "drizzle_state_handshake_client_read",377 drizzle_set_error(con, "drizzle_state_handshake_client_read",
@@ -430,7 +430,7 @@
430 }430 }
431 else431 else
432 {432 {
433 ptr= (uint8_t*)memchr(con->buffer_ptr, 0, con->buffer_size -433 ptr= (unsigned char*)memchr(con->buffer_ptr, 0, con->buffer_size -
434 (34 + strlen(con->user) + scramble_size));434 (34 + strlen(con->user) + scramble_size));
435 if (ptr == NULL)435 if (ptr == NULL)
436 {436 {
@@ -513,7 +513,7 @@
513513
514drizzle_return_t drizzle_state_handshake_client_write(drizzle_st *con)514drizzle_return_t drizzle_state_handshake_client_write(drizzle_st *con)
515{515{
516 uint8_t *ptr;516 unsigned char *ptr;
517 int capabilities;517 int capabilities;
518#ifdef USE_OPENSSL518#ifdef USE_OPENSSL
519 int ssl_ret;519 int ssl_ret;
@@ -600,7 +600,7 @@
600600
601drizzle_return_t drizzle_state_handshake_ssl_client_write(drizzle_st *con)601drizzle_return_t drizzle_state_handshake_ssl_client_write(drizzle_st *con)
602{602{
603 uint8_t *ptr;603 unsigned char *ptr;
604 int capabilities;604 int capabilities;
605605
606 drizzle_log_debug(con, "drizzle_state_handshake_ssl_client_write");606 drizzle_log_debug(con, "drizzle_state_handshake_ssl_client_write");
607607
=== modified file 'libdrizzle/pack.cc'
--- libdrizzle/pack.cc 2012-12-23 01:05:57 +0000
+++ libdrizzle/pack.cc 2013-01-05 11:52:22 +0000
@@ -57,7 +57,7 @@
57 * Compute hash from password and scramble.57 * Compute hash from password and scramble.
58 */58 */
59static drizzle_return_t _pack_scramble_hash(drizzle_st *con,59static drizzle_return_t _pack_scramble_hash(drizzle_st *con,
60 uint8_t *buffer);60 unsigned char *buffer);
6161
62/** @} */62/** @} */
6363
@@ -65,7 +65,7 @@
65 * Public definitions65 * Public definitions
66 */66 */
6767
68uint8_t *drizzle_pack_length(uint64_t number, uint8_t *ptr)68unsigned char *drizzle_pack_length(uint64_t number, unsigned char *ptr)
69{69{
70 if (number < 251)70 if (number < 251)
71 {71 {
@@ -157,7 +157,7 @@
157 return length;157 return length;
158}158}
159159
160uint8_t *drizzle_pack_string(char *string, uint8_t *ptr)160unsigned char *drizzle_pack_string(char *string, unsigned char *ptr)
161{161{
162 if (string == NULL)162 if (string == NULL)
163 {163 {
@@ -176,7 +176,7 @@
176 return ptr;176 return ptr;
177}177}
178178
179uint8_t *drizzle_pack_binary(uint8_t *data, size_t len, uint8_t *ptr)179unsigned char *drizzle_pack_binary(unsigned char *data, size_t len, unsigned char *ptr)
180{180{
181 ptr= drizzle_pack_length(len, ptr);181 ptr= drizzle_pack_length(len, ptr);
182 if (len > 0)182 if (len > 0)
@@ -188,7 +188,7 @@
188 return ptr;188 return ptr;
189}189}
190190
191uint8_t *drizzle_pack_time(drizzle_datetime_st *time, uint8_t *ptr)191unsigned char *drizzle_pack_time(drizzle_datetime_st *time, unsigned char *ptr)
192{192{
193 uint8_t length= 0;193 uint8_t length= 0;
194194
@@ -213,7 +213,7 @@
213 return ptr+length;213 return ptr+length;
214}214}
215215
216uint8_t *drizzle_pack_datetime(drizzle_datetime_st *datetime, uint8_t *ptr)216unsigned char *drizzle_pack_datetime(drizzle_datetime_st *datetime, unsigned char *ptr)
217{217{
218 uint8_t length= 0;218 uint8_t length= 0;
219219
@@ -245,7 +245,7 @@
245 return ptr + length;245 return ptr + length;
246}246}
247247
248void drizzle_unpack_time(drizzle_field_t field, size_t length, uint8_t *data)248void drizzle_unpack_time(drizzle_field_t field, size_t length, unsigned char *data)
249{249{
250 drizzle_datetime_st *datetime= (drizzle_datetime_st*) data;250 drizzle_datetime_st *datetime= (drizzle_datetime_st*) data;
251 memset(datetime, 0, length);251 memset(datetime, 0, length);
@@ -266,7 +266,7 @@
266 }266 }
267}267}
268268
269void drizzle_unpack_datetime(drizzle_field_t field, size_t length, uint8_t *data)269void drizzle_unpack_datetime(drizzle_field_t field, size_t length, unsigned char *data)
270{270{
271 drizzle_datetime_st *datetime= (drizzle_datetime_st*) data;271 drizzle_datetime_st *datetime= (drizzle_datetime_st*) data;
272 memset(datetime, 0, length);272 memset(datetime, 0, length);
@@ -332,7 +332,7 @@
332 return DRIZZLE_RETURN_OK;332 return DRIZZLE_RETURN_OK;
333}333}
334334
335uint8_t *drizzle_pack_auth(drizzle_st *con, uint8_t *ptr,335unsigned char *drizzle_pack_auth(drizzle_st *con, unsigned char *ptr,
336 drizzle_return_t *ret_ptr)336 drizzle_return_t *ret_ptr)
337{337{
338 drizzle_return_t unused_ret;338 drizzle_return_t unused_ret;
@@ -408,11 +408,11 @@
408 */408 */
409409
410static drizzle_return_t _pack_scramble_hash(drizzle_st *con,410static drizzle_return_t _pack_scramble_hash(drizzle_st *con,
411 uint8_t *buffer)411 unsigned char *buffer)
412{412{
413 SHA1_CTX ctx;413 SHA1_CTX ctx;
414 uint8_t hash_tmp1[SHA1_DIGEST_LENGTH];414 unsigned char hash_tmp1[SHA1_DIGEST_LENGTH];
415 uint8_t hash_tmp2[SHA1_DIGEST_LENGTH];415 unsigned char hash_tmp2[SHA1_DIGEST_LENGTH];
416416
417 if (SHA1_DIGEST_LENGTH != DRIZZLE_MAX_SCRAMBLE_SIZE)417 if (SHA1_DIGEST_LENGTH != DRIZZLE_MAX_SCRAMBLE_SIZE)
418 {418 {
@@ -431,7 +431,7 @@
431431
432 /* First hash the password. */432 /* First hash the password. */
433 SHA1Init(&ctx);433 SHA1Init(&ctx);
434 SHA1Update(&ctx, (uint8_t *)(con->password), strlen(con->password));434 SHA1Update(&ctx, (unsigned char *)(con->password), strlen(con->password));
435 SHA1Final(hash_tmp1, &ctx);435 SHA1Final(hash_tmp1, &ctx);
436436
437 /* Second, hash the password hash. */437 /* Second, hash the password hash. */
438438
=== modified file 'libdrizzle/pack.h'
--- libdrizzle/pack.h 2012-12-30 02:23:50 +0000
+++ libdrizzle/pack.h 2013-01-05 11:52:22 +0000
@@ -58,7 +58,7 @@
58 * Pack length-encoded number.58 * Pack length-encoded number.
59 */59 */
6060
61uint8_t *drizzle_pack_length(uint64_t number, uint8_t *ptr);61unsigned char *drizzle_pack_length(uint64_t number, unsigned char *ptr);
6262
63/**63/**
64 * Unpack length-encoded number.64 * Unpack length-encoded number.
@@ -70,17 +70,17 @@
70 * Pack length-encoded string.70 * Pack length-encoded string.
71 */71 */
7272
73uint8_t *drizzle_pack_string(char *string, uint8_t *ptr);73unsigned char *drizzle_pack_string(char *string, unsigned char *ptr);
7474
75uint8_t *drizzle_pack_binary(uint8_t *data, size_t len, uint8_t *ptr);75unsigned char *drizzle_pack_binary(unsigned char *data, size_t len, unsigned char *ptr);
7676
77uint8_t *drizzle_pack_time(drizzle_datetime_st *time, uint8_t *ptr);77unsigned char *drizzle_pack_time(drizzle_datetime_st *time, unsigned char *ptr);
7878
79uint8_t *drizzle_pack_datetime(drizzle_datetime_st *datetime, uint8_t *ptr);79unsigned char *drizzle_pack_datetime(drizzle_datetime_st *datetime, unsigned char *ptr);
8080
81void drizzle_unpack_time(drizzle_field_t field, size_t length, uint8_t *data);81void drizzle_unpack_time(drizzle_field_t field, size_t length, unsigned char *data);
8282
83void drizzle_unpack_datetime(drizzle_field_t field, size_t length, uint8_t *data);83void drizzle_unpack_datetime(drizzle_field_t field, size_t length, unsigned char *data);
8484
85/**85/**
86 * Unpack length-encoded string.86 * Unpack length-encoded string.
@@ -91,7 +91,7 @@
91/**91/**
92 * Pack user, scramble, and db.92 * Pack user, scramble, and db.
93 */93 */
94uint8_t *drizzle_pack_auth(drizzle_st *con, uint8_t *ptr,94unsigned char *drizzle_pack_auth(drizzle_st *con, unsigned char *ptr,
95 drizzle_return_t *ret_ptr);95 drizzle_return_t *ret_ptr);
9696
97/** @} */97/** @} */
9898
=== modified file 'libdrizzle/query.cc'
--- libdrizzle/query.cc 2012-12-22 08:54:15 +0000
+++ libdrizzle/query.cc 2013-01-05 11:52:22 +0000
@@ -47,7 +47,7 @@
47 drizzle_return_t *ret_ptr)47 drizzle_return_t *ret_ptr)
48{48{
49 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_QUERY,49 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_QUERY,
50 (uint8_t *)query, size, size, ret_ptr);50 (unsigned char *)query, size, size, ret_ptr);
51}51}
5252
53drizzle_result_st *drizzle_query_str(drizzle_st *con,53drizzle_result_st *drizzle_query_str(drizzle_st *con,
@@ -62,7 +62,7 @@
62 size_t size= strlen(query);62 size_t size= strlen(query);
6363
64 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_QUERY,64 return drizzle_command_write(con, NULL, DRIZZLE_COMMAND_QUERY,
65 (uint8_t *)query, size, size, ret_ptr);65 (unsigned char *)query, size, size, ret_ptr);
66}66}
6767
6868
@@ -135,7 +135,7 @@
135 return to_size;135 return to_size;
136}136}
137137
138bool drizzle_hex_string(char *to, const uint8_t *from, const size_t from_size)138bool drizzle_hex_string(char *to, const unsigned char *from, const size_t from_size)
139{139{
140 if (to == NULL || from == NULL || from_size == 0)140 if (to == NULL || from == NULL || from_size == 0)
141 {141 {
@@ -143,7 +143,7 @@
143 }143 }
144144
145 static const char hex_map[]= "0123456789ABCDEF";145 static const char hex_map[]= "0123456789ABCDEF";
146 const uint8_t *from_end;146 const unsigned char *from_end;
147147
148 for (from_end= from + from_size; from != from_end; from++)148 for (from_end= from + from_size; from != from_end; from++)
149 {149 {
@@ -164,11 +164,11 @@
164 }164 }
165 165
166 SHA1_CTX ctx;166 SHA1_CTX ctx;
167 uint8_t hash_tmp1[SHA1_DIGEST_LENGTH];167 unsigned char hash_tmp1[SHA1_DIGEST_LENGTH];
168 uint8_t hash_tmp2[SHA1_DIGEST_LENGTH];168 unsigned char hash_tmp2[SHA1_DIGEST_LENGTH];
169169
170 SHA1Init(&ctx);170 SHA1Init(&ctx);
171 SHA1Update(&ctx, (const uint8_t*)from, from_size);171 SHA1Update(&ctx, (const unsigned char*)from, from_size);
172 SHA1Final(hash_tmp1, &ctx);172 SHA1Final(hash_tmp1, &ctx);
173173
174 SHA1Init(&ctx);174 SHA1Init(&ctx);
175175
=== modified file 'libdrizzle/statement.cc'
--- libdrizzle/statement.cc 2012-12-31 10:02:02 +0000
+++ libdrizzle/statement.cc 2013-01-05 11:52:22 +0000
@@ -116,9 +116,9 @@
116 drizzle_bind_st *param_ptr;116 drizzle_bind_st *param_ptr;
117 size_t param_lengths= 0;117 size_t param_lengths= 0;
118 size_t buffer_size= 0;118 size_t buffer_size= 0;
119 uint8_t *buffer;119 unsigned char *buffer;
120 uint8_t *buffer_pos;120 unsigned char *buffer_pos;
121 uint8_t *data_pos;121 unsigned char *data_pos;
122 drizzle_return_t ret;122 drizzle_return_t ret;
123123
124 /* Calculate param lengths */124 /* Calculate param lengths */
@@ -141,7 +141,7 @@
141 + (stmt->param_count * 2) /* Parameter type data */141 + (stmt->param_count * 2) /* Parameter type data */
142 + param_lengths; /* Parameter data */142 + param_lengths; /* Parameter data */
143143
144 buffer = (uint8_t*)malloc(buffer_size);144 buffer = (unsigned char*)malloc(buffer_size);
145 if (buffer == NULL)145 if (buffer == NULL)
146 {146 {
147 drizzle_set_error(stmt->con, __func__, "malloc");147 drizzle_set_error(stmt->con, __func__, "malloc");
@@ -258,7 +258,7 @@
258 case DRIZZLE_COLUMN_TYPE_STRING:258 case DRIZZLE_COLUMN_TYPE_STRING:
259 case DRIZZLE_COLUMN_TYPE_DECIMAL:259 case DRIZZLE_COLUMN_TYPE_DECIMAL:
260 case DRIZZLE_COLUMN_TYPE_NEWDECIMAL:260 case DRIZZLE_COLUMN_TYPE_NEWDECIMAL:
261 data_pos= drizzle_pack_binary((uint8_t*)param_ptr->data, param_ptr->length, data_pos);261 data_pos= drizzle_pack_binary((unsigned char*)param_ptr->data, param_ptr->length, data_pos);
262 break;262 break;
263 /* These types aren't handled yet, most are for older MySQL versions */263 /* These types aren't handled yet, most are for older MySQL versions */
264 case DRIZZLE_COLUMN_TYPE_INT24:264 case DRIZZLE_COLUMN_TYPE_INT24:
@@ -316,10 +316,10 @@
316 return ret;316 return ret;
317}317}
318318
319drizzle_return_t drizzle_stmt_send_long_data(drizzle_stmt_st *stmt, uint16_t param_num, uint8_t *data, size_t len)319drizzle_return_t drizzle_stmt_send_long_data(drizzle_stmt_st *stmt, uint16_t param_num, unsigned char *data, size_t len)
320{320{
321 drizzle_return_t ret;321 drizzle_return_t ret;
322 uint8_t *buffer;322 unsigned char *buffer;
323323
324 if ((stmt == NULL) || (param_num >= stmt->param_count))324 if ((stmt == NULL) || (param_num >= stmt->param_count))
325 {325 {
@@ -336,7 +336,7 @@
336 /* TODO: rework drizzle_command_write so we can send a header and we don't336 /* TODO: rework drizzle_command_write so we can send a header and we don't
337 * need this copy337 * need this copy
338 * */338 * */
339 buffer= (uint8_t*)malloc(len + 6);339 buffer= (unsigned char*)malloc(len + 6);
340340
341 drizzle_set_byte4(buffer, stmt->id);341 drizzle_set_byte4(buffer, stmt->id);
342 drizzle_set_byte2(&buffer[4], param_num);342 drizzle_set_byte2(&buffer[4], param_num);
@@ -355,7 +355,7 @@
355drizzle_return_t drizzle_stmt_reset(drizzle_stmt_st *stmt)355drizzle_return_t drizzle_stmt_reset(drizzle_stmt_st *stmt)
356{356{
357 drizzle_return_t ret;357 drizzle_return_t ret;
358 uint8_t buffer[4];358 unsigned char buffer[4];
359 uint16_t current_param;359 uint16_t current_param;
360360
361 if (stmt == NULL)361 if (stmt == NULL)
@@ -474,12 +474,12 @@
474 memcpy(param->data, row[column_counter], 8);474 memcpy(param->data, row[column_counter], 8);
475 break;475 break;
476 case DRIZZLE_COLUMN_TYPE_TIME:476 case DRIZZLE_COLUMN_TYPE_TIME:
477 drizzle_unpack_time(row[column_counter], param->length, (uint8_t*)param->data);477 drizzle_unpack_time(row[column_counter], param->length, (unsigned char*)param->data);
478 break;478 break;
479 case DRIZZLE_COLUMN_TYPE_DATE:479 case DRIZZLE_COLUMN_TYPE_DATE:
480 case DRIZZLE_COLUMN_TYPE_DATETIME:480 case DRIZZLE_COLUMN_TYPE_DATETIME:
481 case DRIZZLE_COLUMN_TYPE_TIMESTAMP:481 case DRIZZLE_COLUMN_TYPE_TIMESTAMP:
482 drizzle_unpack_datetime(row[column_counter], param->length, (uint8_t*)param->data);482 drizzle_unpack_datetime(row[column_counter], param->length, (unsigned char*)param->data);
483 break;483 break;
484 case DRIZZLE_COLUMN_TYPE_TINY_BLOB:484 case DRIZZLE_COLUMN_TYPE_TINY_BLOB:
485 case DRIZZLE_COLUMN_TYPE_MEDIUM_BLOB:485 case DRIZZLE_COLUMN_TYPE_MEDIUM_BLOB:
@@ -544,7 +544,7 @@
544544
545drizzle_return_t drizzle_stmt_close(drizzle_stmt_st *stmt)545drizzle_return_t drizzle_stmt_close(drizzle_stmt_st *stmt)
546{546{
547 uint8_t buffer[4];547 unsigned char buffer[4];
548 drizzle_return_t ret;548 drizzle_return_t ret;
549549
550 if (stmt == NULL)550 if (stmt == NULL)
551551
=== modified file 'libdrizzle/statement_local.h'
--- libdrizzle/statement_local.h 2012-12-30 20:08:04 +0000
+++ libdrizzle/statement_local.h 2013-01-05 11:52:22 +0000
@@ -59,6 +59,9 @@
59DRIZZLE_LOCAL59DRIZZLE_LOCAL
60char *timestamp_to_string(drizzle_bind_st *param, drizzle_datetime_st *timestamp);60char *timestamp_to_string(drizzle_bind_st *param, drizzle_datetime_st *timestamp);
6161
62DRIZZLE_LOCAL
63uint16_t drizzle_stmt_column_lookup(drizzle_result_st *result, const char *column_name, drizzle_return_t *ret_ptr);
64
62#ifdef __cplusplus65#ifdef __cplusplus
63}66}
64#endif67#endif
6568
=== modified file 'libdrizzle/statement_param.cc'
--- libdrizzle/statement_param.cc 2012-12-31 09:54:55 +0000
+++ libdrizzle/statement_param.cc 2013-01-05 11:52:22 +0000
@@ -168,6 +168,21 @@
168 return drizzle_stmt_set_param(stmt, param_num, DRIZZLE_COLUMN_TYPE_TIME, timestamp, 0, false, true);168 return drizzle_stmt_set_param(stmt, param_num, DRIZZLE_COLUMN_TYPE_TIME, timestamp, 0, false, true);
169}169}
170170
171bool drizzle_stmt_get_is_null_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
172{
173 uint16_t column_number;
174 if ((stmt == NULL) || (stmt->result_params == NULL))
175 {
176 *ret_ptr= DRIZZLE_RETURN_INVALID_ARGUMENT;
177 }
178 column_number= drizzle_stmt_column_lookup(stmt->prepare_result, column_name, ret_ptr);
179 if (*ret_ptr != DRIZZLE_RETURN_OK)
180 {
181 return 0;
182 }
183 return drizzle_stmt_get_is_null(stmt, column_number, ret_ptr);
184}
185
171bool drizzle_stmt_get_is_null(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)186bool drizzle_stmt_get_is_null(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
172{187{
173 if ((stmt == NULL) || (stmt->result_params == NULL) || (column_number >= stmt->execute_result->column_count))188 if ((stmt == NULL) || (stmt->result_params == NULL) || (column_number >= stmt->execute_result->column_count))
@@ -180,6 +195,21 @@
180 return stmt->result_params[column_number].options.is_null;195 return stmt->result_params[column_number].options.is_null;
181}196}
182197
198bool drizzle_stmt_get_is_unsigned_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
199{
200 uint16_t column_number;
201 if ((stmt == NULL) || (stmt->result_params == NULL))
202 {
203 *ret_ptr= DRIZZLE_RETURN_INVALID_ARGUMENT;
204 }
205 column_number= drizzle_stmt_column_lookup(stmt->prepare_result, column_name, ret_ptr);
206 if (*ret_ptr != DRIZZLE_RETURN_OK)
207 {
208 return 0;
209 }
210 return drizzle_stmt_get_is_unsigned(stmt, column_number, ret_ptr);
211}
212
183bool drizzle_stmt_get_is_unsigned(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)213bool drizzle_stmt_get_is_unsigned(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
184{214{
185 if ((stmt == NULL) || (stmt->result_params == NULL) || (column_number >= stmt->execute_result->column_count))215 if ((stmt == NULL) || (stmt->result_params == NULL) || (column_number >= stmt->execute_result->column_count))
@@ -192,6 +222,21 @@
192 return stmt->result_params[column_number].options.is_unsigned;222 return stmt->result_params[column_number].options.is_unsigned;
193}223}
194224
225const char *drizzle_stmt_get_string_from_name(drizzle_stmt_st *stmt, const char *column_name, size_t *len, drizzle_return_t *ret_ptr)
226{
227 uint16_t column_number;
228 if ((stmt == NULL) || (stmt->result_params == NULL))
229 {
230 *ret_ptr= DRIZZLE_RETURN_INVALID_ARGUMENT;
231 }
232 column_number= drizzle_stmt_column_lookup(stmt->prepare_result, column_name, ret_ptr);
233 if (*ret_ptr != DRIZZLE_RETURN_OK)
234 {
235 return 0;
236 }
237 return drizzle_stmt_get_string(stmt, column_number, len, ret_ptr);
238}
239
195const char *drizzle_stmt_get_string(drizzle_stmt_st *stmt, uint16_t column_number, size_t *len, drizzle_return_t *ret_ptr)240const char *drizzle_stmt_get_string(drizzle_stmt_st *stmt, uint16_t column_number, size_t *len, drizzle_return_t *ret_ptr)
196{241{
197 char *val;242 char *val;
@@ -276,6 +321,21 @@
276 return val;321 return val;
277}322}
278323
324uint32_t drizzle_stmt_get_int_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
325{
326 uint16_t column_number;
327 if ((stmt == NULL) || (stmt->result_params == NULL))
328 {
329 *ret_ptr= DRIZZLE_RETURN_INVALID_ARGUMENT;
330 }
331 column_number= drizzle_stmt_column_lookup(stmt->prepare_result, column_name, ret_ptr);
332 if (*ret_ptr != DRIZZLE_RETURN_OK)
333 {
334 return 0;
335 }
336 return drizzle_stmt_get_int(stmt, column_number, ret_ptr);
337}
338
279uint32_t drizzle_stmt_get_int(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)339uint32_t drizzle_stmt_get_int(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
280{340{
281 uint32_t val;341 uint32_t val;
@@ -350,6 +410,21 @@
350 return val;410 return val;
351}411}
352412
413uint64_t drizzle_stmt_get_bigint_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
414{
415 uint16_t column_number;
416 if ((stmt == NULL) || (stmt->result_params == NULL))
417 {
418 *ret_ptr= DRIZZLE_RETURN_INVALID_ARGUMENT;
419 }
420 column_number= drizzle_stmt_column_lookup(stmt->prepare_result, column_name, ret_ptr);
421 if (*ret_ptr != DRIZZLE_RETURN_OK)
422 {
423 return 0;
424 }
425 return drizzle_stmt_get_bigint(stmt, column_number, ret_ptr);
426}
427
353uint64_t drizzle_stmt_get_bigint(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)428uint64_t drizzle_stmt_get_bigint(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
354{429{
355 uint32_t val;430 uint32_t val;
@@ -420,6 +495,21 @@
420 return val;495 return val;
421}496}
422497
498double drizzle_stmt_get_double_from_name(drizzle_stmt_st *stmt, const char *column_name, drizzle_return_t *ret_ptr)
499{
500 uint16_t column_number;
501 if ((stmt == NULL) || (stmt->result_params == NULL))
502 {
503 *ret_ptr= DRIZZLE_RETURN_INVALID_ARGUMENT;
504 }
505 column_number= drizzle_stmt_column_lookup(stmt->prepare_result, column_name, ret_ptr);
506 if (*ret_ptr != DRIZZLE_RETURN_OK)
507 {
508 return 0;
509 }
510 return drizzle_stmt_get_double(stmt, column_number, ret_ptr);
511}
512
423double drizzle_stmt_get_double(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)513double drizzle_stmt_get_double(drizzle_stmt_st *stmt, uint16_t column_number, drizzle_return_t *ret_ptr)
424{514{
425 double val;515 double val;
@@ -557,3 +647,18 @@
557 }647 }
558 return param->converted_data;648 return param->converted_data;
559}649}
650
651uint16_t drizzle_stmt_column_lookup(drizzle_result_st *result, const char *column_name, drizzle_return_t *ret_ptr)
652{
653 uint16_t current_column;
654 for (current_column= 0; current_column < result->column_count; current_column++)
655 {
656 if (strncmp(column_name, result->column_buffer[current_column].name, DRIZZLE_MAX_COLUMN_NAME_SIZE) == 0)
657 {
658 *ret_ptr= DRIZZLE_RETURN_OK;
659 return current_column;
660 }
661 }
662 *ret_ptr= DRIZZLE_RETURN_NOT_FOUND;
663 return 0;
664}
560665
=== modified file 'libdrizzle/structs.h'
--- libdrizzle/structs.h 2012-12-30 20:08:04 +0000
+++ libdrizzle/structs.h 2013-01-05 11:52:22 +0000
@@ -166,23 +166,23 @@
166 size_t command_total;166 size_t command_total;
167 size_t packet_size;167 size_t packet_size;
168 struct addrinfo *addrinfo_next;168 struct addrinfo *addrinfo_next;
169 uint8_t *buffer_ptr;169 unsigned char *buffer_ptr;
170 uint8_t *command_buffer;170 unsigned char *command_buffer;
171 uint8_t *command_data;171 unsigned char *command_data;
172 void *context;172 void *context;
173 drizzle_context_free_fn *context_free_fn;173 drizzle_context_free_fn *context_free_fn;
174 drizzle_result_st *result;174 drizzle_result_st *result;
175 drizzle_result_st *result_list;175 drizzle_result_st *result_list;
176 uint8_t *scramble;176 unsigned char *scramble;
177 union177 union
178 {178 {
179 drizzle_tcp_st tcp;179 drizzle_tcp_st tcp;
180 drizzle_uds_st uds;180 drizzle_uds_st uds;
181 } socket;181 } socket;
182 uint8_t buffer[DRIZZLE_MAX_BUFFER_SIZE];182 unsigned char buffer[DRIZZLE_MAX_BUFFER_SIZE];
183 char db[DRIZZLE_MAX_DB_SIZE];183 char db[DRIZZLE_MAX_DB_SIZE];
184 char password[DRIZZLE_MAX_PASSWORD_SIZE];184 char password[DRIZZLE_MAX_PASSWORD_SIZE];
185 uint8_t scramble_buffer[DRIZZLE_MAX_SCRAMBLE_SIZE];185 unsigned char scramble_buffer[DRIZZLE_MAX_SCRAMBLE_SIZE];
186 char server_version[DRIZZLE_MAX_SERVER_VERSION_SIZE];186 char server_version[DRIZZLE_MAX_SERVER_VERSION_SIZE];
187 char server_extra[DRIZZLE_MAX_SERVER_EXTRA_SIZE];187 char server_extra[DRIZZLE_MAX_SERVER_EXTRA_SIZE];
188 drizzle_state_fn *state_stack[DRIZZLE_STATE_STACK_SIZE];188 drizzle_state_fn *state_stack[DRIZZLE_STATE_STACK_SIZE];
@@ -305,8 +305,8 @@
305 uint16_t flags;305 uint16_t flags;
306 uint16_t extra_flags;306 uint16_t extra_flags;
307 uint32_t checksum;307 uint32_t checksum;
308 uint8_t *data;308 unsigned char *data;
309 uint8_t *raw_data;309 unsigned char *raw_data;
310 uint32_t raw_length;310 uint32_t raw_length;
311};311};
312312
@@ -331,7 +331,7 @@
331 drizzle_column_type_t type;331 drizzle_column_type_t type;
332 int flags;332 int flags;
333 uint8_t decimals;333 uint8_t decimals;
334 uint8_t default_value[DRIZZLE_MAX_DEFAULT_VALUE_SIZE];334 unsigned char default_value[DRIZZLE_MAX_DEFAULT_VALUE_SIZE];
335 size_t default_value_size;335 size_t default_value_size;
336};336};
337337
338338
=== modified file 'tests/unit/column.c'
--- tests/unit/column.c 2012-12-31 00:06:53 +0000
+++ tests/unit/column.c 2013-01-05 11:52:22 +0000
@@ -71,7 +71,7 @@
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 drizzle_result_st *result= drizzle_select_db(con, "libdrizzle", &ret);74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int primary key auto_increment, b varchar(255), c timestamp default current_timestamp)", &ret);77 drizzle_query_str(con, "create table libdrizzle.t1 (a int primary key auto_increment, b varchar(255), c timestamp default current_timestamp)", &ret);
@@ -80,7 +80,7 @@
80 drizzle_query_str(con, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')", &ret);80 drizzle_query_str(con, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')", &ret);
81 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')");81 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values ('this'),('is'),('war')");
8282
83 result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);83 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);
84 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "select * from libdrizzle.t1");84 ASSERT_TRUE_(ret == DRIZZLE_RETURN_OK, "select * from libdrizzle.t1");
8585
86 drizzle_result_buffer(result);86 drizzle_result_buffer(result);
8787
=== modified file 'tests/unit/hex.c'
--- tests/unit/hex.c 2012-12-29 10:49:09 +0000
+++ tests/unit/hex.c 2013-01-05 11:52:22 +0000
@@ -45,7 +45,7 @@
4545
46int main(int argc, char* argv[])46int main(int argc, char* argv[])
47{47{
48 const uint8_t in[6]= {0x00, 0xFF, 0x7F, 0x80, 0xB9, 0xC0};48 const unsigned char in[6]= {0x00, 0xFF, 0x7F, 0x80, 0xB9, 0xC0};
49 char out[255];49 char out[255];
50 bool result;50 bool result;
5151
5252
=== modified file 'tests/unit/insert_id.c'
--- tests/unit/insert_id.c 2012-12-31 00:06:53 +0000
+++ tests/unit/insert_id.c 2013-01-05 11:52:22 +0000
@@ -70,13 +70,13 @@
70 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);70 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);
71 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));71 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7272
73 drizzle_result_st *result= drizzle_select_db(con, "libdrizzle", &ret);73 ret= drizzle_select_db(con, "libdrizzle");
74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7575
76 drizzle_query_str(con, "create table libdrizzle.t1 (a int primary key auto_increment, b int)", &ret);76 drizzle_query_str(con, "create table libdrizzle.t1 (a int primary key auto_increment, b int)", &ret);
77 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "create table libdrizzle.t1 (a int primary key auto_increment, b int)");77 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "create table libdrizzle.t1 (a int primary key auto_increment, b int)");
7878
79 result= drizzle_query_str(con, "insert into libdrizzle.t1 (b) values (1),(2),(3)", &ret);79 drizzle_result_st *result= drizzle_query_str(con, "insert into libdrizzle.t1 (b) values (1),(2),(3)", &ret);
80 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values (1),(2),(3)");80 ASSERT_EQ_(ret, DRIZZLE_RETURN_OK, "insert into libdrizzle.t1 (b) values (1),(2),(3)");
81 ASSERT_TRUE(result);81 ASSERT_TRUE(result);
8282
8383
=== modified file 'tests/unit/query.c'
--- tests/unit/query.c 2012-12-31 00:06:53 +0000
+++ tests/unit/query.c 2013-01-05 11:52:22 +0000
@@ -71,7 +71,7 @@
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 drizzle_result_st *result= drizzle_select_db(con, "libdrizzle", &ret);74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);
@@ -88,7 +88,7 @@
88 return EXIT_FAILURE;88 return EXIT_FAILURE;
89 }89 }
9090
91 result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);91 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);
92 if (ret != DRIZZLE_RETURN_OK)92 if (ret != DRIZZLE_RETURN_OK)
93 {93 {
94 printf("Select failure\n");94 printf("Select failure\n");
9595
=== modified file 'tests/unit/row.c'
--- tests/unit/row.c 2012-12-31 00:06:53 +0000
+++ tests/unit/row.c 2013-01-05 11:52:22 +0000
@@ -71,7 +71,7 @@
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 drizzle_result_st *result= drizzle_select_db(con, "libdrizzle", &ret);74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);
@@ -88,7 +88,7 @@
88 return EXIT_FAILURE;88 return EXIT_FAILURE;
89 }89 }
9090
91 result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);91 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);
92 if (ret != DRIZZLE_RETURN_OK)92 if (ret != DRIZZLE_RETURN_OK)
93 {93 {
94 printf("Select failure\n");94 printf("Select failure\n");
9595
=== modified file 'tests/unit/statement.c'
--- tests/unit/statement.c 2012-12-31 09:54:55 +0000
+++ tests/unit/statement.c 2013-01-05 11:52:22 +0000
@@ -73,8 +73,7 @@
73 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);73 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);
74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));74 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7575
76 drizzle_result_st *result= drizzle_select_db(con, "libdrizzle", &ret);76 ret= drizzle_select_db(con, "libdrizzle");
77 ASSERT_TRUE(result);
78 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");77 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7978
80 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);79 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);
@@ -133,6 +132,13 @@
133 printf("Retrieved unexpected int value\n");132 printf("Retrieved unexpected int value\n");
134 return EXIT_FAILURE;133 return EXIT_FAILURE;
135 }134 }
135 res_val= drizzle_stmt_get_int_from_name(stmt, "a", &ret);
136 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "drizzle_stmt_get_int (char col name)");
137 if (res_val != i)
138 {
139 printf("Rerieved unexpected int value with char col name\n");
140 return EXIT_FAILURE;
141 }
136 snprintf(comp_val, 3, "%"PRIu32, i);142 snprintf(comp_val, 3, "%"PRIu32, i);
137 if (strcmp(comp_val, char_val) != 0)143 if (strcmp(comp_val, char_val) != 0)
138 {144 {
139145
=== modified file 'tests/unit/statement_char.c'
--- tests/unit/statement_char.c 2012-12-31 09:59:37 +0000
+++ tests/unit/statement_char.c 2013-01-05 11:52:22 +0000
@@ -74,8 +74,7 @@
74 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);74 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7676
77 drizzle_result_st *result= drizzle_select_db(con, "libdrizzle", &ret);77 ret= drizzle_select_db(con, "libdrizzle");
78 ASSERT_TRUE(result);
79 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");78 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
8079
81 drizzle_query_str(con, "create table libdrizzle.t1 (a varchar(50))", &ret);80 drizzle_query_str(con, "create table libdrizzle.t1 (a varchar(50))", &ret);
8281
=== modified file 'tests/unit/unbuffered_query.c'
--- tests/unit/unbuffered_query.c 2012-12-31 00:06:53 +0000
+++ tests/unit/unbuffered_query.c 2013-01-05 11:52:22 +0000
@@ -71,7 +71,7 @@
71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);71 drizzle_query_str(con, "CREATE SCHEMA libdrizzle", &ret);
72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));72 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "CREATE SCHEMA libdrizzle (%s)", drizzle_error(con));
7373
74 drizzle_result_st *result= drizzle_select_db(con, "libdrizzle", &ret);74 ret= drizzle_select_db(con, "libdrizzle");
75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");75 ASSERT_EQ_(DRIZZLE_RETURN_OK, ret, "USE libdrizzle");
7676
77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);77 drizzle_query_str(con, "create table libdrizzle.t1 (a int)", &ret);
@@ -88,7 +88,7 @@
88 return EXIT_FAILURE;88 return EXIT_FAILURE;
89 }89 }
9090
91 result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);91 drizzle_result_st *result= drizzle_query_str(con, "select * from libdrizzle.t1", &ret);
92 if (ret != DRIZZLE_RETURN_OK)92 if (ret != DRIZZLE_RETURN_OK)
93 {93 {
94 printf("Select failure\n");94 printf("Select failure\n");

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: