Code review comment for lp:~linaro-validation/lava-core/main

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hi. This seems mostly fine. Two comments:

1) I don't think the help for -D is quite right: yes it enables DEBUG on the root logger, but the debug output only goes to ~/.cache/lava/logs/debug.log right? The way the help is written I think I expected it to be on stdout/stderr. I think the behaviour you have is better, can you update the description.

2) When I run lava-dev --help, I see this: http://people.linaro.org/~mwh/lava-dev-help.png -- all that epilog stuff is not what I want to see! Compare bzr --help or git --help. It's good information and should be accessible somewhere, but maybe it should be somewhere else? I don't know where. bzr has 'topics' -- bzr help topics -- maybe something like that?

« Back to merge proposal