Code review comment for lp:~linaro-landing-team-samsung/linaro-image-tools/add-origen-android-support

Hi Mathias

On Wed, Aug 24, 2011 at 2:40 AM, Mattias Backman
<email address hidden> wrote:
>> === modified file 'linaro_image_tools/media_create/boards.py'
>> --- linaro_image_tools/media_create/boards.py   2011-08-19 13:59:34 +0000
>> +++ linaro_image_tools/media_create/boards.py   2011-08-22 17:31:41 +0000
>> @@ -1049,7 +1049,10 @@
>>
>>     @classmethod
>>     def populate_raw_partition(cls, chroot_dir, boot_device_or_file):
>> -        # Populate created raw partition with BL1, env and u-boot
>> +        # Zero the env so that the boot_script will get loaded
>> +        _dd("/dev/zero", boot_device_or_file, count=SAMSUNG_V310_ENV_LEN,
>> +            seek=SAMSUNG_V310_ENV_START)
>
> If you're sure that this is ok for both Origen and SMDKV310, it's fine
> by me. It will affect both boards, for Android and non-Android, but
> all the other boards will be unaffected.
>

In the Android case the boot.scr should take over an in the Ubuntu
case the flashable_env will get written after this.

>> +        # Populate created raw partition with BL1 and u-boot
>>         spl_file = os.path.join(chroot_dir, 'boot', 'u-boot-mmc-spl.bin')
>>         assert os.path.getsize(spl_file) <= (SAMSUNG_V310_BL1_LEN * SECTOR_SIZE), (
>>             "%s is larger than SAMSUNG_V310_BL1_LEN" % spl_file)
>>
>>
>>
>
> --
> https://code.launchpad.net/~linaro-landing-team-samsung/linaro-image-tools/add-origen-android-support/+merge/72465
> Your team Linaro Landing Team: Samsung is subscribed to branch lp:~linaro-landing-team-samsung/linaro-image-tools/add-origen-android-support.
>

--
Angus Ainslie <email address hidden>
Team Lead, Samsung Landing Team