Code review comment for lp:~linaro-landing-team-samsung/linaro-image-tools/add-origen-android-support

Revision history for this message
Mattias Backman (mabac) wrote :

> === modified file 'linaro_image_tools/media_create/boards.py'
> --- linaro_image_tools/media_create/boards.py   2011-08-19 13:59:34 +0000
> +++ linaro_image_tools/media_create/boards.py   2011-08-22 17:31:41 +0000
> @@ -1049,7 +1049,10 @@
>
>     @classmethod
>     def populate_raw_partition(cls, chroot_dir, boot_device_or_file):
> -        # Populate created raw partition with BL1, env and u-boot
> +        # Zero the env so that the boot_script will get loaded
> +        _dd("/dev/zero", boot_device_or_file, count=SAMSUNG_V310_ENV_LEN,
> +            seek=SAMSUNG_V310_ENV_START)

If you're sure that this is ok for both Origen and SMDKV310, it's fine
by me. It will affect both boards, for Android and non-Android, but
all the other boards will be unaffected.

> +        # Populate created raw partition with BL1 and u-boot
>         spl_file = os.path.join(chroot_dir, 'boot', 'u-boot-mmc-spl.bin')
>         assert os.path.getsize(spl_file) <= (SAMSUNG_V310_BL1_LEN * SECTOR_SIZE), (
>             "%s is larger than SAMSUNG_V310_BL1_LEN" % spl_file)
>
>
>

« Back to merge proposal