Merge lp:~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga into lp:linaro-image-tools/11.11

Proposed by Eric Miao
Status: Rejected
Rejected by: Loïc Minier
Proposed branch: lp:~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga
Merge into: lp:linaro-image-tools/11.11
Diff against target: 11 lines (+1/-0)
1 file modified
linaro_media_create/boards.py (+1/-0)
To merge this branch: bzr merge lp:~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga
Reviewer Review Type Date Requested Status
Linaro Maintainers Pending
Review via email: mp+54147@code.launchpad.net

Description of the change

This fixed the issue of VGA not enabled by default by providing the correct kernel command line.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

On Mon, 21 Mar 2011 03:54:54 -0000, Eric Miao <email address hidden> wrote:
> Eric Miao has proposed merging lp:~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga into lp:linaro-image-tools.
>
> Requested reviews:
> Linaro Maintainers (linaro-maintainers)
>
> For more details, see:
> https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga/+merge/54147
>
> This fixed the issue of VGA not enabled by default by providing the correct kernel command line.
> --
> https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga/+merge/54147
> Your team Linaro Infrastructure is subscribed to branch lp:linaro-image-tools.
> === modified file 'linaro_media_create/boards.py'
> --- linaro_media_create/boards.py 2011-03-17 17:48:49 +0000
> +++ linaro_media_create/boards.py 2011-03-21 03:54:44 +0000
> @@ -474,6 +474,7 @@
> initrd_addr = '0x71800000'
> load_addr = '0x70008000'
> kernel_suffix = 'linaro-lt-mx53'
> + extra_boot_args_options = ('di1_primary tve ')
>
>
> class EfikamxConfig(Mx51Config):
>

From IRC:

<james_w> ericm, about https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx53loco-fixvga/+merge/54147 , what does the option actually do?
<ericm> james_w, it's for enabling display output on mx53 loco board
<james_w> right, is there some way that it could be the default?
<ericm> james_w, it's possible though
<james_w> it's better if the kernel just gets it right, so I'd prefer not to merge that if we can avoid it
<ericm> james_w, ok - got you
<james_w> ericm, great, are you going to pursue that approach?
* ronynandy has quit (Remote host closed the connection)
<ericm> james_w, I'll take a look - not really sure if it's feasible with Freescale's existing kernel
<james_w> ok, let me know what you find
<ericm> james_w, sure
<ericm_> james_w, I believe I have to discuss this option with Freescale tomorrow, will get back to you then
<james_w> ericm_, ok, thanks

Thanks,

James

Revision history for this message
Eric Miao (eric.y.miao) wrote :

This can be done within the kernel. Please drop this merge proposal.

Revision history for this message
Loïc Minier (lool) wrote :

Done (you might want to mark your branch as abandoned too)

Unmerged revisions

293. By Eric Miao

mx53loco: add extra command line to enable VGA output

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_media_create/boards.py'
2--- linaro_media_create/boards.py 2011-03-17 17:48:49 +0000
3+++ linaro_media_create/boards.py 2011-03-21 03:54:44 +0000
4@@ -474,6 +474,7 @@
5 initrd_addr = '0x71800000'
6 load_addr = '0x70008000'
7 kernel_suffix = 'linaro-lt-mx53'
8+ extra_boot_args_options = ('di1_primary tve ')
9
10
11 class EfikamxConfig(Mx51Config):

Subscribers

People subscribed via source and target branches