Code review comment for lp:~linaro-infrastructure/linaro-ci-dashboard/models-design

Revision history for this message
Данило Шеган (danilo) wrote :

It would be good if we could have the "dependencies" not be a .phony target (i.e. build them only when necessary), so we could have tests and run depend on it.

Is the "syncdb" call needed/usable with south? I believe we need to use "migrate" command instead.

And we should definitely rebase before landing this (removal of the jenkinsjob from the frontend is a clear example of what we don't want to keep references of).

For JenkinsJob/JenkinsBuild, I believe we do not really need them: having a Loop and LoopBuild classes in the frontend should be enough. They should not really depend on the Jenkins classes, except for the minimal global interface (like "run a build", "get build results", "is build finished", etc.).

review: Needs Fixing

« Back to merge proposal