Code review comment for lp:~linaro-infrastructure/linaro-ci-dashboard/models-design

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

Overall changes looks good. Some suggestion here:

An important field of the Build record should be a build number.
so we need to make bnum = models.Integer(PrimaryKey=True) as part of the JenkinsBuild Model.

I would prefer not to expose the password in the initial_data.json fixture. This is not secure.
We should probably have a variable in settings.py which we import and set the values to these fields later.
We should provide dummy values to these variables and merge it in upstream and when we actually deploy this
on production use the actual values to set them.
Also, we should make use of the API token instead of the using the plain passwords.

Thanks!!!
Deepti.

review: Needs Fixing

« Back to merge proposal