On 03/04/12 20:59, Steve Kowalik wrote:
> Review: Approve code
>
> Broadly this looks good. I think you should run format-imports on the files you've changed or added, some of them are not quite right.
Cool, I'll do that.
>
> I'm not really happy with "registry.upcoming_work_view.enabled" as a feature flag name -- perhaps it should move to blueprints.
The problem is that the new page actually spans across blueprints and
bugs; that's why it is on the default layer and not blueprints.
Thanks for the review, Steve.
On 03/04/12 20:59, Steve Kowalik wrote:
> Review: Approve code
>
> Broadly this looks good. I think you should run format-imports on the files you've changed or added, some of them are not quite right.
Cool, I'll do that.
> upcoming_ work_view. enabled" as a feature flag name -- perhaps it should move to blueprints.
> I'm not really happy with "registry.
The problem is that the new page actually spans across blueprints and
bugs; that's why it is on the default layer and not blueprints.