Code review comment for lp:~linaro-infrastructure/cbuild/cbuild-scheduler_cbuild-lava

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> The other thing is including if-else bash structures in the yaml file: can we have a separate bash script and run that one?

As oftentimes happens, a viable solution, IMHO, lies somewhere between these these two extremes: 1) put everything in YAML, and 2) host everything in separate repo(s) and pull it from YAML. If we host somewhere elsewhere, there're number of questions to consider: 1) where to host it; 2) how easy it will be to find/change it; 3) how easy to pull it where needed (for example, we could put each small script into own repo, but fetch dozen of repos is boring when doing local test). When there were good answers to those questions, I put it outside, for example "./workaround-multiarch.sh" which is standalone, reusable script. But setup/wrapper code is best in YAML, imho.

Btw, that if you quoted can be removed now - it remnant from previous work (I originally wanted to make a common YAML testdef for all builds, but for flexibility, now they're per queue, and something live in "panda" queue is not supposed to run qemu).

« Back to merge proposal