Code review comment for lp:~linaro-infrastructure/cbuild/cbuild-scheduler_cbuild-lava

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> I see that there is a mix of syntax: some steps are quoted, some are not. It definitely will work on both cases, it is more from a consistency point of view. Was puzzled actually by how the yaml parser will handle that, but it handles them correctly anyway.

In YAML, string quotes can be omitted, if it can be parsed unambiguously. Yes, to be on safe side (and be consistent) we can quote everything. But that's just character noise which affects readability. So, I'd personally not quoted unless really required (that would be less consistently-looking, but see better than arrays of stray quotes imho). Current content may not adhere to the above is it was cut&pasted originally. If you agree with that idea (quote only if needed), let's fix it.

« Back to merge proposal