Code review comment for lp:~linaro-infrastructure/cbuild/cbuild-scheduler_cbuild-lava

On Wed, Jan 9, 2013 at 4:41 PM, Stevan Radaković
<email address hidden> wrote:
>> The other thing is including if-else bash structures in the yaml file: can we
>> have a separate bash script and run that one? Or do we need to do other things
>> before it is possible to achieve that: like sending the file to lava, etc. I
>> know it's a couple of lines and is just the template... (oddily we might even
>> move all the steps in a bash script and just execute that one).
>
> I'm not sure if this can be done, but anyway I fail to see the difference between the current approach and the one you described. Only if we can extract some piece of shell code that would be used in multiple templates scripts would this make sense. But if it makes sense to try and play around with this approach we can certainly do so.

Basically, it changes nothing, apart from the re-use point of view.
The only difference I could see is that it looks clumsy to write
multiple lines of bash shell in a yaml-like syntax (that gets
converted into a shell script anyway after that).

--
Milo Casagrande | Infrastructure Team
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs