Code review comment for lp:~linaro-graphics-wg/nux/nux-1.0-gles2

On Wed, Sep 7, 2011 at 7:55 PM, Jay Taoko <email address hidden> wrote:
> There changes needed to get this branch working with unity.
>
> - In IOpenGLGLSLShader.cpp line 1904
> The code that is removed is necessary to load some shaders. We have shaders that contains the "#version" information in unity. Also, "#version" information in a GLSL shader is valid and we need to preserve it even if it is not supported by GLSL.
>
> - One problem I have encountered many times is the support of macros in GLSL with intel drivers. My last check a few months ago showed that Intel's driver didn't support macros very well. So I am not sure that "#ifdef GL_ES" will work with Intel driver on the desktop... I still have to check. If the intel's driver still fails with macros in GLSL, I think we could use the C++ pre-processor to enable the GL_ES bits in the shaders.

This would be a huge bug for them as this is precisely how Khronos
recommends doing this (explicitly part of the preprocessor details;
GLSL is not supposed to define it whereas GLSL ES is).

cheers,
jesse

>
> - Around line 1037
> Some texture format definitions have been invalidated... For formats that are not available in OpenGL ES, they removed with macros in the C++ pre-processor.
>
>
> --
> https://code.launchpad.net/~linaro-graphics-wg/nux/nux-gles2/+merge/70279
> Your team Linaro Graphics Working Group is subscribed to branch lp:~linaro-graphics-wg/nux/nux-gles2.
>