Code review comment for lp:~linaro-graphics-wg/nux/nux-1.0-gles2
Revision history for this message
| Travis Watkins (amaranth) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I removed the #version lines because GLES GLSL uses different versions than GL GLSL even if they support the same features. I also removed them from unity so there should be no problems caused by that. The only solution that would allow keeping the #version lines is to #ifdef them in C++ so the correct version is generated depending on what you are compiling for but it didn't seem worthwhile.
There is no specific GLSL compiler for intel so I assume you mean mesa here. Mesa's GLSL compiler certainly supports #ifdef and I've been using the mesa GL and GLES stacks with an intel GPU while testing.
These are only invalidated in the GLES codepath, do you mean I should remove them in a different way?