Code review comment for lp:~linaro-automation/linaro-ci/one-time-submission-job

Revision history for this message
Alexander Sack (asac) wrote :

>
> 3. + git remote rm "$remote_tree_alias_name"
> => I think this cleanup should be moved to a block that gets always executed
> (even in case of error). there is a signal syntax to catch errors and jump to
> a cleanup code block in sh we could use.

here background on this: http://steve-parker.org/sh/trap.shtml

we wantt he cleanup code to be run in case of error and if things go smooth.

« Back to merge proposal