Code review comment for lp:~linaro-automation/linaro-ci/one-time-submission-job

1. + if test -z "$git_branch_ref" ; then
 => I think this and all other sanity checks of input parameters should be moved to the top.

2. since we have quite a few variables and input parameters here itmight make sense to use special syntax for input parameters (like all uppercase, or param_... prefix etc.)

3. + git remote rm "$remote_tree_alias_name"
 => I think this cleanup should be moved to a block that gets always executed (even in case of error). there is a signal syntax to catch errors and jump to a cleanup code block in sh we could use.

4. i am not sure if the cleanup code should be going back to master branch; I dont think it is always the right thing; there can be trees that have no master branch etc. iirc jenkins creates its own branch names. check what branch you are on if you enter the script and switch back to that maybe.

5. I feel we duplicate loads of code here that could be reused from the "normal" kenrel CI job; either refactor things now, or add a blueprint about code-reuse-effort-for-jenkins-scripts.