Code review comment for lp:~lin-yu/purchase-wkfl/add_purchase_price_list
Revision history for this message
| Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote | # |
review:
Disapprove
(code review, no tests)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi Lin,
Thanks for this contribs ! Do you really need to override the whole function "price_get_multi" without calling super() ?
This can lead in very unexpected result so for now I marks it as Disapprove for that reason. Other module that may override this method can face trouble due to that...
Thanks for your understanding or explanation if I do missed something !
Regards,