Code review comment for lp:~lin-yu/purchase-wkfl/add_purchase_po_price

Dear Joël,
Thanks for your reply.
I will work on it and make it more clear.

BR,
On 09/11/2013 10:57 PM, Joël Grand-Guillaume @ camptocamp wrote:
> Review: Needs Information code review, functionnal
>
> Hi Lin,
>
> Thanks for the contribution ! A got some stuff I'm not sure about in this module.
>
> 1) The description only mention "Enable/Disable control on PO Price" it's a bit too short.
>
> 2) Lots of other fields (I mean not related to the control of price) is present on PO Line, like qty_received, qty_unreceived,.. Those field do not seems to me related to the purpose of the module.. I don't actually know if it really make sens to have them here. Any pointer ?
>
> 3) Field like modify_price do not seems to be used, sequence serve another purpose than the one I see in this module
>
> What I suggest is that you firstly make a better explanation of the purpose and use of the module. Once done, we can discuss further on what to let in there and what not. On my own opinion, this module should only forbid to change the price in PO if not allowed for this supplier.
>
> Best regards,
>
>

--
LIN Yu

LIN Yu
/Project Manager/
--
*Elico Corporation, Shanghai
/OpenERP Premium Certified Training Partner/ *
Cell: + 86 186 1691 1351
Office: + 86 21 6211 8017/27
Skype: llccluf
<email address hidden> <mailto:<email address hidden>>
http://www.elico-corp.com

Elico Corp