Merge lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/bug_1317236_default_image into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Proposed by Andrew P.
Status: Merged
Merge reported by: Simon Steinbeiß
Merged at revision: not available
Proposed branch: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/bug_1317236_default_image
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 26 lines (+4/-2)
1 file modified
src/lightdm-gtk-greeter.c (+4/-2)
To merge this branch: bzr merge lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/bug_1317236_default_image
Reviewer Review Type Date Requested Status
Simon Steinbeiß Approve
Review via email: mp+219085@code.launchpad.net

Description of the change

Bugfix for #1317236:

set_user_image() is not called if users list is hidden => default-user-image option is not applied to user_image

To post a comment you must log in.
Revision history for this message
Simon Steinbeiß (ochosi) wrote :

I've successfully reproduced the bug now and also tested the patch. Great work once again, Andrew!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/lightdm-gtk-greeter.c'
--- src/lightdm-gtk-greeter.c 2014-05-02 11:03:59 +0000
+++ src/lightdm-gtk-greeter.c 2014-05-10 00:49:23 +0000
@@ -727,11 +727,12 @@
727set_user_image (const gchar *username)727set_user_image (const gchar *username)
728{728{
729 const gchar *path;729 const gchar *path;
730 LightDMUser *user;730 LightDMUser *user = NULL;
731 GdkPixbuf *image = NULL;731 GdkPixbuf *image = NULL;
732 GError *error = NULL;732 GError *error = NULL;
733733
734 user = lightdm_user_list_get_user_by_name (lightdm_user_list_get_instance (), username);734 if (username)
735 user = lightdm_user_list_get_user_by_name (lightdm_user_list_get_instance (), username);
735 if (user)736 if (user)
736 {737 {
737 path = lightdm_user_get_image (user);738 path = lightdm_user_get_image (user);
@@ -2700,6 +2701,7 @@
2700 {2701 {
2701 /* Set the background to default */2702 /* Set the background to default */
2702 set_background (NULL);2703 set_background (NULL);
2704 set_user_image (NULL);
2703 start_authentication ("*other");2705 start_authentication ("*other");
2704 }2706 }
2705 else2707 else

Subscribers

People subscribed via source and target branches