Code review comment for lp:~lifeless/testtools/matchers

Thanks for doing this.

doc/for-test-authors.rst:
 * The heading for the IsInstance matcher is "Is", should be "IsInstance".

testtools/testcase.py
 * Please delete the XXX in assertThat about taking an optional message parameter.
 * The line "raise matchee[0], matchee[1], matchee[2]" is invalid syntax in Python 3. Use testtools.compat.reraise(*matchee) instead.
 * Is there a reason that expectFailure wasn't also changed?

Generally, the new failure messages for the negative assert methods (e.g. assertNotIn) are worse than the current ones. To some extent, this would be addressed by a fix for bug 704219.

Separately from this branch, I think we want to provide an In or IsIn matcher to complement Contains.