Code review comment for lp:~lifeless/storm/with

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

> While the column list isn't required, it seems more robust to list the column names
> for cases where you would have duplicate names otherwise. I also don't think we'd
> make life any easier by automatically aliasing the columns to something like _1, _2, etc.

Sounds good.

Please note that I wasn't suggesting using aliases. We might simply not get into the
business of defining the query in detail, in a way similar to how we don't detail
how the CREATE TABLE is run with its column names.

But having a With type which is closer to the other types (Select, Update, etc) sounds
good too.

« Back to merge proposal