Code review comment for lp:~lifeless/storm/with

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

[1]

> we could rename using to from_ (another keyword :( ...) or perhaps
> store.use_with and store.use_from or something like that.

Doesn't seem significantly better.

The WITH clause seems somewhat similar in essence to an alias, except
the definition of the alias is more than a simple rename. This means
that pretty much every location in Storm which could accept a table
can theoretically be defined with the help of a WITH clause.

I'm wondering if we might come up with a "With" type that could
optionally be defined name-less (similar to how Alias works), and be
used anywhere a real table can be.

> We're going to run a fork in LP for the moment - we need this feature
> to solve performance problems.

Please don't. We know what will happen next.

Launchpad has survived for years without this feature, so please
wait a bit longer and let's actually sort out the right way to do it.

You'll not want to go around patching code once we determine the way
that is going to be integrated, and will effectively be living with a
fork forever.

« Back to merge proposal