Code review comment for lp:~lifeless/storm/with

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

[1]

199 + result = self.store.with_(SQL("tmp as (select 20 as id)")).using(Foo
200 + ).find(Foo.title, SQL("foo.id in (select id from tmp)"));
201 + self.assertEqual(list(result), [u'Title 20'])

We'll have to think a bit more about the interface here. The proposed one seems
hard to reason about and will certainly yield confusion regarding the distinction
between with_() and using(), which are undistinguishable from a developer
standpoint.

review: Needs Fixing

« Back to merge proposal