Code review comment for lp:~lifeless/python-oops-tools/polish

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Is there no HTML test that would covers this at all? I do have a few concerns:

 * Out of interest, any idea how costly it is to record, and later, render tracebacks for every event?

 * What about HTML-escaping? What if the traceback contained a line like:

        123, "</pre>", (a < b))

—wouldn't that upset the rendered HTML? Not likely to be a big problem for us, I suppose, but if we want this code to be reusable…

review: Needs Information

« Back to merge proposal