Code review comment for lp:~lifeless/launchpad/cachedproperty

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Hi,

This looks good. I'm not sure what value there is in initializing _cached_properties in SQLBase.__init__ is -- seems to slightly increase coupling.

Generally, yay for safer-by-default.

Cheers,
mwh

review: Approve

« Back to merge proposal