Code review comment for lp:~lifeless/launchpad/bug-759467

Revision history for this message
Gavin Panella (allenap) wrote :

Looks good.

- status = EnumCol(
+ _status = EnumCol(

Did you consider subclassing EnumCol instead of doing this?

Also, any other places that want to select with BugTask.status are
going to access an underscore property. It might have been clearer to
call it db_status or something like that.

review: Approve

« Back to merge proposal